Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 260713002: Add use counters for the hspace/vspace attributes on <table> (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, adamk+blink_chromium.org
Visibility:
Public.

Description

Add use counters for the hspace/vspace attributes on <table> There's also a Gecko bug and a spec bug on this: https://bugzilla.mozilla.org/show_bug.cgi?id=725646 https://www.w3.org/Bugs/Public/show_bug.cgi?id=23039 BUG=277080 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173041

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
philipj_slow
PTAL.
6 years, 7 months ago (2014-04-30 11:53:36 UTC) #1
Julien - ping for review
Enthusiastic LGTM!
6 years, 7 months ago (2014-04-30 21:41:55 UTC) #2
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 7 months ago (2014-04-30 21:41:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/260713002/1
6 years, 7 months ago (2014-04-30 21:42:18 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 21:42:27 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-04-30 21:42:27 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-04-30 22:06:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/260713002/20001
6 years, 7 months ago (2014-04-30 22:06:30 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 22:26:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink
6 years, 7 months ago (2014-04-30 22:26:24 UTC) #10
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-04-30 22:37:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/260713002/20001
6 years, 7 months ago (2014-04-30 22:37:31 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 23:52:44 UTC) #13
Message was sent while issue was closed.
Change committed as 173041

Powered by Google App Engine
This is Rietveld 408576698