Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc

Issue 2607063002: Remove mojo::Array. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc
diff --git a/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc b/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc
index 02da15dcda673a2cc4fce01fa2bc7ca73ebeb4b5..ee81945153797a142b3457c02ceee2780f3a0d08 100644
--- a/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc
+++ b/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc
@@ -20,7 +20,7 @@ namespace extensions {
class WiFiDisplayMediaServiceImpl::PacketIOBuffer : public net::IOBuffer {
public:
- explicit PacketIOBuffer(mojo::Array<uint8_t> array);
+ explicit PacketIOBuffer(std::vector<uint8_t> array);
yzshen1 2017/01/06 19:38:38 Does it make sense to use &&?
Sam McNally 2017/01/09 23:15:15 Yes, but the style guide doesn't allow it.
yzshen1 2017/01/09 23:20:24 I feel that this falls in the "move constructor" c
Sam McNally 2017/01/09 23:30:11 A move constructor requires the input type to be t
int size() const { return packet_data_.size(); }
@@ -31,7 +31,7 @@ class WiFiDisplayMediaServiceImpl::PacketIOBuffer : public net::IOBuffer {
};
WiFiDisplayMediaServiceImpl::PacketIOBuffer::PacketIOBuffer(
- mojo::Array<uint8_t> array) {
+ std::vector<uint8_t> array) {
array.Swap(&packet_data_);
data_ = reinterpret_cast<char*>(packet_data_.data());
}

Powered by Google App Engine
This is Rietveld 408576698