[Autofill] Credit Card Autofill Last Used Date Experiment

components/autofill_strings.grdp

Index: components/autofill_strings.grdp
diff --git a/components/autofill_strings.grdp b/components/autofill_strings.grdp
index ac4e1c06f7924de80407223ae27f7a9b47b55f39..700fa9dd9625df7d6ae3cb60307c753a4d4a2f71 100644
--- a/components/autofill_strings.grdp
+++ b/components/autofill_strings.grdp
@@ -247,6 +247,30 @@
     , exp <ph name="EXPIRATION_DATE_ABBR">$1<ex>06/17</ex></ph>
   </message>
 
+  <message name="IDS_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_LABEL_AND_EXP_WITH_DETAIL" desc="text displayed in the Autofill Credit Card popup to indicate the date when this card is last used.">

[Jared Saul, 2017/01/18 18:43:44]

s/desc="text/desc="Text (here and below)

[Jared Saul, 2017/01/18 18:43:44]

s/is last used/was last used (here and below)

[jiahuiguo, 2017/01/18 22:18:13]

Done.

[jiahuiguo, 2017/01/18 22:18:13]

Done.

+    , last used: <ph name="LAST_USED_MONTH">$1<ex>Feb</ex></ph> <ph name="LAST_USED_DAY_OF_MONTH">$2<ex>17</ex></ph> at <ph name="LAST_USED_HOUR">$3<ex>10</ex></ph>:<ph name="LAST_USED_MINUTE">$4<ex>00</ex></ph>

[Mathieu, 2017/01/18 14:42:15]

Can you look at
https://cs.chromium.org/chromium/src/base/i18n/time_formatting.cc?type=cs&q=i...
? I don't really like that we are reinventing date formatting

[Jared Saul, 2017/01/18 18:43:44]

I also don't like that some of these messages arbitrarily start with commas and
are lowercase; the translators aren't going to know what that's all about, and
it seems like something we should be able to abstract away from the
translations...

[jiahuiguo, 2017/01/18 22:18:13]

Thanks for pointing this out, I utilize this API to format HH:MM. For the exact
date, the API will show year info, which we do not need in this UI.

[jiahuiguo, 2017/01/18 22:18:13]

Done.

+  </message>
+  
+  <message name="IDS_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_LABEL_AND_EXP_NO_DETAIL" desc="text displayed in the Autofill Credit Card popup to indicate the date when this card is last used.">
+    , last used: <ph name="LAST_USED_MONTH">$1<ex>Feb</ex></ph> <ph name="LAST_USED_DAY_OF_MONTH">$2<ex>17</ex></ph>
+  </message>
+  
+  <message name="IDS_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_LABEL_WITH_DETAIL" desc="text displayed in the Autofill Credit Card popup to indicate the date when this card is last used.">
+    Last used: <ph name="LAST_USED_MONTH">$1<ex>Feb</ex></ph> <ph name="LAST_USED_DAY_OF_MONTH">$2<ex>17</ex></ph> at <ph name="LAST_USED_HOUR">$3<ex>10</ex></ph>:<ph name="LAST_USED_MINUTE">$4<ex>00</ex></ph>
+  </message>
+  
+  <message name="IDS_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_LABEL_NO_DETAIL" desc="text displayed in the Autofill Credit Card popup to indicate the date when this card is last used.">
+    Last used: <ph name="LAST_USED_MONTH">$1<ex>Feb</ex></ph> <ph name="LAST_USED_DAY_OF_MONTH">$2<ex>17</ex></ph>
+  </message>
+  
+  <message name="IDS_AUTOFILL_CREDIT_CARD_ADDED_TO_CHROME_DATE_LABEL_AND_EXP" desc="text displayed in the Autofill Credit Card popup to indicate the date when this card is added to Chrome autofill.">
+    , added to Chrome: <ph name="Added_TO_CHROME_MONTH">$1<ex>Feb</ex></ph> <ph name="Added_TO_CHROME_DAY_OF_MONTH">$2<ex>17</ex></ph>
+  </message>
+  
+  <message name="IDS_AUTOFILL_CREDIT_CARD_ADDED_TO_CHROME_DATE_LABEL" desc="text displayed in the Autofill Credit Card popup to indicate the date when this card is added to Chrome autofill.">
+    Added to Chrome: <ph name="Added_TO_CHROME_MONTH">$1<ex>Feb</ex></ph> <ph name="Added_TO_CHROME_DAY_OF_MONTH">$2<ex>17</ex></ph>
+  </message>
+  
   <!-- Autofill credit card unmask prompt -->
   <message name="IDS_AUTOFILL_CARD_UNMASK_PROMPT_ERROR_TRY_AGAIN_CVC" desc="Error message that encourages the user to try to re-enter their credit card CVC after a previous failed attempt." formatter_data="android_java">
     Check your CVC and try again