[Autofill] Credit Card Autofill Last Used Date Experiment

components/autofill/core/browser/credit_card.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_
 
 #include <iosfwd>
 #include <string>
 #include <utility>
@@ skipping 156 matching lines @@
   // Returns true if all field types have valid values set and the card is not
   // expired. MASKED_SERVER_CARDs will never be valid because the number is
   // not complete.
   bool IsValid() const;
 
   // Returns the credit card number.
   const base::string16& number() const { return number_; }
   // Sets |number_| to |number| and computes the appropriate card |type_|.
   void SetNumber(const base::string16& number);
 
-  // Logs the number of days since the credit card was last used and records its
-  // use.
+  // Returns the date(MM/DD) when the credit card was last used in autofill.
+  base::string16 LastUsedDateAsString(
+      bool show_time_detail,

[Jared Saul, 2017/01/18 18:43:44]

Based on outcome of my previous comment, should this be show_detailed_time_info
for consistency?

[jiahuiguo, 2017/01/18 22:18:13]

Done.

+      bool show_expiration_date,

[Jared Saul, 2017/01/18 18:43:44]

super nit: Likewise, show_expiration_date has come before
show_detailed_time_info everywhere else.  Can we swap these to keep the ordering
consistent?

[jiahuiguo, 2017/01/18 22:18:13]

Done.

+      const std::string& app_locale) const;
+
+  // Logs the number of days since the credit card was last used and records
+  // its use.
   void RecordAndLogUse();
 
   // Converts a string representation of a month (such as "February" or "feb."
   // or "2") into a numeric value in [1, 12]. Returns true on successful
   // conversion or false if a month was not recognized.
   static bool ConvertMonth(const base::string16& month,
                            const std::string& app_locale,
                            int* num);
 
+  base::string16 GetShortMonthLabel(int32_t zero_base_month_index,
+                                    const std::string& app_locale) const;
+
   // Returns whether the credit card is expired based on |current_time|.
   bool IsExpired(const base::Time& current_time) const;
 
   // Whether the card expiration date should be updated.
   bool ShouldUpdateExpiration(const base::Time& current_time) const;
 
   const std::string& billing_address_id() const { return billing_address_id_; }
   void set_billing_address_id(const std::string& id) {
     billing_address_id_ = id;
   }
 
  private:
   FRIEND_TEST_ALL_PREFIXES(CreditCardTest, SetExpirationDateFromString);
   FRIEND_TEST_ALL_PREFIXES(CreditCardTest, SetExpirationYearFromString);
 
   // FormGroup:
   void GetSupportedTypes(ServerFieldTypeSet* supported_types) const override;
 
   // The type of the card to fill in to the page, e.g. 'Mastercard'.
   base::string16 TypeForFill() const;
 
   // The month and year are zero if not present.
   int Expiration4DigitYear() const { return expiration_year_; }
   int Expiration2DigitYear() const { return expiration_year_ % 100; }
   base::string16 ExpirationMonthAsString() const;
   base::string16 Expiration4DigitYearAsString() const;
   base::string16 Expiration2DigitYearAsString() const;
 
+  // Padding month and day info to exactly 2 digits

[Jared Saul, 2017/01/18 18:43:44]

nit: Add period; looks like that's the norm around here

[jiahuiguo, 2017/01/18 22:18:13]

Done.

+  base::string16 PadTo2Digit(int32_t dateInfo) const;

[Mathieu, 2017/01/18 14:42:15]

can this be in the anonymous namespace in the cc file?

[Mathieu, 2017/01/18 14:42:15]

nit: date_info

[jiahuiguo, 2017/01/18 22:18:13]

Done.

[jiahuiguo, 2017/01/18 22:18:13]

Good point, done.

+
   // Sets |expiration_month_| to the integer conversion of |text| and returns
   // whether the operation was successful.
   bool SetExpirationMonthFromString(const base::string16& text,
                                     const std::string& app_locale);
 
   // Sets |expiration_year_| to the integer conversion of |text|. Will handle
   // 4-digit year or 2-digit year (eventually converted to 4-digit year).
   void SetExpirationYearFromString(const base::string16& text);
 
   // Sets |expiration_year_| and |expiration_month_| to the integer conversion
@@ skipping 40 matching lines @@
 extern const char kGenericCard[];
 extern const char kJCBCard[];
 extern const char kMasterCard[];
 extern const char kMirCard[];
 extern const char kUnionPay[];
 extern const char kVisaCard[];
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_