[Autofill] Credit Card Autofill Last Used Date Experiment

components/autofill/core/browser/credit_card.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_
 
 #include <iosfwd>
 #include <string>
 #include <utility>
@@ skipping 156 matching lines @@
   // Returns true if all field types have valid values set and the card is not
   // expired. MASKED_SERVER_CARDs will never be valid because the number is
   // not complete.
   bool IsValid() const;
 
   // Returns the credit card number.
   const base::string16& number() const { return number_; }
   // Sets |number_| to |number| and computes the appropriate card |type_|.
   void SetNumber(const base::string16& number);
 
+  // Returns the date(MM/DD) when the credit card was last used in autofill

[Jared Saul, 2017/01/04 22:01:24]

nit: Add period at end

[jiahuiguo, 2017/01/18 00:13:44]

Done.

+  base::string16 LastUsedDateAsString() const;
+
   // Logs the number of days since the credit card was last used and records its
   // use.
   void RecordAndLogUse();
 
   // Converts a string representation of a month (such as "February" or "feb."
   // or "2") into a numeric value in [1, 12]. Returns true on successful
   // conversion or false if a month was not recognized.
   static bool ConvertMonth(const base::string16& month,
                            const std::string& app_locale,
                            int* num);
@@ skipping 19 matching lines @@
   // The type of the card to fill in to the page, e.g. 'Mastercard'.
   base::string16 TypeForFill() const;
 
   // The month and year are zero if not present.
   int Expiration4DigitYear() const { return expiration_year_; }
   int Expiration2DigitYear() const { return expiration_year_ % 100; }
   base::string16 ExpirationMonthAsString() const;
   base::string16 Expiration4DigitYearAsString() const;
   base::string16 Expiration2DigitYearAsString() const;
 
+  // Formatting month or day info to exact 2 digits

[csashi, 2017/01/03 20:54:06]

Is it not "month *and* day" ?

[csashi, 2017/01/03 20:54:06]

exactly 2 digits

[jiahuiguo, 2017/01/18 00:13:45]

Done.

[jiahuiguo, 2017/01/18 00:13:45]

Done.

+  base::string16 FormatDateTo2Digit(int dateInfo) const;

[csashi, 2017/01/03 20:54:06]

Is it 2 digits? MM/DD is 4 digits.

[Jared Saul, 2017/01/04 22:01:23]

Yeah but this function only takes a certain part of it at a time (day, month,
etc.)  Perhaps just rename to "FormatTo2Digits(int dateInfo)" instead?

[jiahuiguo, 2017/01/18 00:13:45]

Done.

[jiahuiguo, 2017/01/18 00:13:45]

It only formats month or day for each call, return either MM or DD.

+
   // Sets |expiration_month_| to the integer conversion of |text| and returns
   // whether the operation was successful.
   bool SetExpirationMonthFromString(const base::string16& text,
                                     const std::string& app_locale);
 
   // Sets |expiration_year_| to the integer conversion of |text|. Will handle
   // 4-digit year or 2-digit year (eventually converted to 4-digit year).
   void SetExpirationYearFromString(const base::string16& text);
 
   // Sets |expiration_year_| and |expiration_month_| to the integer conversion
@@ skipping 40 matching lines @@
 extern const char kGenericCard[];
 extern const char kJCBCard[];
 extern const char kMasterCard[];
 extern const char kMirCard[];
 extern const char kUnionPay[];
 extern const char kVisaCard[];
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_