[Autofill] Credit Card Autofill Last Used Date Experiment

components/autofill/core/browser/credit_card.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/credit_card.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 765 matching lines @@
 
 void CreditCard::SetNumber(const base::string16& number) {
   number_ = number;
 
   // Set the type based on the card number, but only for full numbers, not
   // when we have masked cards from the server (last 4 digits).
   if (record_type_ != MASKED_SERVER_CARD)
     type_ = GetCreditCardType(StripSeparators(number_));
 }
 
+base::string16 CreditCard::LastUsedDateAsString() const {
+  base::Time::Exploded exploded;
+  use_date().LocalExplode(&exploded);
+  base::string16 month = FormatDateTo2Digit(exploded.month);
+  base::string16 day_of_month = FormatDateTo2Digit(exploded.day_of_month);
+  base::string16 hour = FormatDateTo2Digit(exploded.hour);
+  base::string16 minute = FormatDateTo2Digit(exploded.minute);

[csashi, 2017/01/03 20:54:06]

You do not need hour and minutes unless use_count() > 1.

[jiahuiguo, 2017/01/18 00:13:44]

Good point!

+  return use_count() > 1
+             ? l10n_util::GetStringFUTF16(
+                 IDS_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_LABEL,
+                 month,
+                 day_of_month,
+                 hour,
+                 minute)
+             : l10n_util::GetStringFUTF16(
+                 IDS_AUTOFILL_CREDIT_CARD_ADDED_TO_CHROME_DATE_LABEL,
+                 month,
+                 day_of_month);
+}
+
+base::string16 CreditCard::FormatDateTo2Digit(int date_info) const {
+  DCHECK(date_info > 0);
+  base::string16 dateIn2Digit = base::IntToString16(date_info);
+  if (date_info >= 10)
+    return dateIn2Digit;
+
+  base::string16 zero = ASCIIToUTF16("0");
+  zero.append(dateIn2Digit);
+  return zero;

[csashi, 2017/01/03 20:54:06]

You are not returning zero. May be call this padded_date (or equivalent)?

[jiahuiguo, 2017/01/18 00:13:44]

Done.

+}
+
 void CreditCard::RecordAndLogUse() {
   UMA_HISTOGRAM_COUNTS_1000("Autofill.DaysSinceLastUse.CreditCard",
                             (base::Time::Now() - use_date()).InDays());
   RecordUse();
 }
 
 // static
 bool CreditCard::ConvertMonth(const base::string16& month,
                               const std::string& app_locale,
                               int* num) {
@@ skipping 76 matching lines @@
 const char kDinersCard[] = "dinersCC";
 const char kDiscoverCard[] = "discoverCC";
 const char kGenericCard[] = "genericCC";
 const char kJCBCard[] = "jcbCC";
 const char kMasterCard[] = "masterCardCC";
 const char kMirCard[] = "mirCC";
 const char kUnionPay[] = "unionPayCC";
 const char kVisaCard[] = "visaCC";
 
 }  // namespace autofill