Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2607043002: [Autofill] Credit Card Autofill Last Used Date Experiment (Closed)
Patch Set: Addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | components/autofill/core/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 652 matching lines...) Expand 10 before | Expand all | Expand 10 after
663 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight, 663 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight,
664 arraysize( 664 arraysize(
665 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight), 665 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight),
666 nullptr}, 666 nullptr},
667 {"Display credit card icon at start and increase dropdown item height", 667 {"Display credit card icon at start and increase dropdown item height",
668 kAutofillCreditCardPopupLayoutFeatureVariationExpanded, 668 kAutofillCreditCardPopupLayoutFeatureVariationExpanded,
669 arraysize(kAutofillCreditCardPopupLayoutFeatureVariationExpanded), 669 arraysize(kAutofillCreditCardPopupLayoutFeatureVariationExpanded),
670 nullptr}}; 670 nullptr}};
671 #endif // OS_ANDROID 671 #endif // OS_ANDROID
672 672
673 const FeatureEntry::FeatureParam
674 kAutofillCreditCardLastUsedDateFeatureVariationExpDate[] = {
675 {"show_expiration_date", "true"}};
676
677 const FeatureEntry::FeatureVariation
678 kAutofillCreditCardLastUsedDateFeatureVariations[] = {
679 {"Display expiration date",
680 kAutofillCreditCardLastUsedDateFeatureVariationExpDate,
681 arraysize(kAutofillCreditCardLastUsedDateFeatureVariationExpDate),
682 nullptr}};
683
673 // RECORDING USER METRICS FOR FLAGS: 684 // RECORDING USER METRICS FOR FLAGS:
674 // ----------------------------------------------------------------------------- 685 // -----------------------------------------------------------------------------
675 // The first line of the entry is the internal name. 686 // The first line of the entry is the internal name.
676 // 687 //
677 // To add a new entry, add to the end of kFeatureEntries. There are two 688 // To add a new entry, add to the end of kFeatureEntries. There are two
678 // distinct types of entries: 689 // distinct types of entries:
679 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE 690 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE
680 // macro for this type supplying the command line to the macro. 691 // macro for this type supplying the command line to the macro.
681 // . MULTI_VALUE: a list of choices, the first of which should correspond to a 692 // . MULTI_VALUE: a list of choices, the first of which should correspond to a
682 // deactivated state for this lab (i.e. no command line option). To specify 693 // deactivated state for this lab (i.e. no command line option). To specify
(...skipping 1465 matching lines...) Expand 10 before | Expand all | Expand 10 after
2148 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT, 2159 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT,
2149 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT_DESCRIPTION, 2160 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT_DESCRIPTION,
2150 kOsAndroid, FEATURE_WITH_VARIATIONS_VALUE_TYPE( 2161 kOsAndroid, FEATURE_WITH_VARIATIONS_VALUE_TYPE(
2151 autofill::kAutofillCreditCardPopupLayout, 2162 autofill::kAutofillCreditCardPopupLayout,
2152 kAutofillCreditCardPopupLayoutFeatureVariations, 2163 kAutofillCreditCardPopupLayoutFeatureVariations,
2153 "AutofillCreditCardPopupLayout")}, 2164 "AutofillCreditCardPopupLayout")},
2154 {"native-android-history-manager", IDS_NATIVE_ANDROID_HISTORY_MANAGER, 2165 {"native-android-history-manager", IDS_NATIVE_ANDROID_HISTORY_MANAGER,
2155 IDS_NATIVE_ANDROID_HISTORY_MANAGER_DESCRIPTION, kOsAndroid, 2166 IDS_NATIVE_ANDROID_HISTORY_MANAGER_DESCRIPTION, kOsAndroid,
2156 FEATURE_VALUE_TYPE(features::kNativeAndroidHistoryManager)}, 2167 FEATURE_VALUE_TYPE(features::kNativeAndroidHistoryManager)},
2157 #endif // OS_ANDROID 2168 #endif // OS_ANDROID
2158 2169 {"enable-autofill-credit-card-last-used-date-display",
2170 IDS_FLAGS_ENABLE_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_DISPLAY,
2171 IDS_FLAGS_ENABLE_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_DISPLAY_DESCRIPTION,
2172 kOsAll, FEATURE_WITH_VARIATIONS_VALUE_TYPE(
2173 autofill::kAutofillCreditCardLastUsedDateDisplay,
2174 kAutofillCreditCardLastUsedDateFeatureVariations,
2175 "AutofillCreditCardLastUsedDate")},
2159 #if defined(OS_WIN) 2176 #if defined(OS_WIN)
2160 {"windows10-custom-titlebar", IDS_FLAGS_WINDOWS10_CUSTOM_TITLEBAR_NAME, 2177 {"windows10-custom-titlebar", IDS_FLAGS_WINDOWS10_CUSTOM_TITLEBAR_NAME,
2161 IDS_FLAGS_WINDOWS10_CUSTOM_TITLEBAR_DESCRIPTION, kOsWin, 2178 IDS_FLAGS_WINDOWS10_CUSTOM_TITLEBAR_DESCRIPTION, kOsWin,
2162 SINGLE_VALUE_TYPE(switches::kWindows10CustomTitlebar)}, 2179 SINGLE_VALUE_TYPE(switches::kWindows10CustomTitlebar)},
2163 #endif // OS_WIN 2180 #endif // OS_WIN
2164 2181
2165 {"enable-faster-location-reload", IDS_FLAGS_FASTER_LOCATION_RELOAD_NAME, 2182 {"enable-faster-location-reload", IDS_FLAGS_FASTER_LOCATION_RELOAD_NAME,
2166 IDS_FLAGS_FASTER_LOCATION_RELOAD_DESCRIPTION, kOsAll, 2183 IDS_FLAGS_FASTER_LOCATION_RELOAD_DESCRIPTION, kOsAll,
2167 FEATURE_VALUE_TYPE(features::kFasterLocationReload)}, 2184 FEATURE_VALUE_TYPE(features::kFasterLocationReload)},
2168 #if defined(OS_ANDROID) 2185 #if defined(OS_ANDROID)
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
2410 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2427 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2411 2428
2412 const FeatureEntry* GetFeatureEntries(size_t* count) { 2429 const FeatureEntry* GetFeatureEntries(size_t* count) {
2413 *count = arraysize(kFeatureEntries); 2430 *count = arraysize(kFeatureEntries);
2414 return kFeatureEntries; 2431 return kFeatureEntries;
2415 } 2432 }
2416 2433
2417 } // namespace testing 2434 } // namespace testing
2418 2435
2419 } // namespace about_flags 2436 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | components/autofill/core/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698