Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2607043002: [Autofill] Credit Card Autofill Last Used Date Experiment (Closed)
Patch Set: Addressed reviewer's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 662 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight, 673 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight,
674 arraysize( 674 arraysize(
675 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight), 675 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight),
676 nullptr}, 676 nullptr},
677 {"Display credit card icon at start and increase dropdown item height", 677 {"Display credit card icon at start and increase dropdown item height",
678 kAutofillCreditCardPopupLayoutFeatureVariationExpanded, 678 kAutofillCreditCardPopupLayoutFeatureVariationExpanded,
679 arraysize(kAutofillCreditCardPopupLayoutFeatureVariationExpanded), 679 arraysize(kAutofillCreditCardPopupLayoutFeatureVariationExpanded),
680 nullptr}}; 680 nullptr}};
681 #endif // OS_ANDROID 681 #endif // OS_ANDROID
682 682
683 #if defined(OS_ANDROID)
684 const FeatureEntry::FeatureParam
685 kAutofillCreditCardLastUsedDateFeatureVariationExpDate[] = {
686 {"show_expiration_date", "true"}};
687
688 const FeatureEntry::FeatureParam
689 kAutofillCreditCardLastUsedDateFeatureVariationTimeDetail[] = {
690 {"show_time_detail", "true"}};
691
692 const FeatureEntry::FeatureParam
693 kAutofillCreditCardLastUsedDateFeatureVariationExpDateAndTimeDetail[] = {
694 {"show_expiration_date", "true"},
695 {"show_time_detail", "true"}};
696
697 const FeatureEntry::FeatureVariation
698 kAutofillCreditCardLastUsedDateFeatureVariations[] = {
699 {"Display expiration date",
700 kAutofillCreditCardLastUsedDateFeatureVariationExpDate,
701 arraysize(
702 kAutofillCreditCardLastUsedDateFeatureVariationExpDate),
703 nullptr},
704 {"Display time detail",
705 kAutofillCreditCardLastUsedDateFeatureVariationTimeDetail,
706 arraysize(
707 kAutofillCreditCardLastUsedDateFeatureVariationTimeDetail),
708 nullptr},
709 {"Display expiration date and time detail",
710 kAutofillCreditCardLastUsedDateFeatureVariationExpDateAndTimeDetail,
711 arraysize(
712 kAutofillCreditCardLastUsedDateFeatureVariationExpDateAndTimeDetail),
713 nullptr}};
714 #endif // OS_ANDROID
715
683 // RECORDING USER METRICS FOR FLAGS: 716 // RECORDING USER METRICS FOR FLAGS:
684 // ----------------------------------------------------------------------------- 717 // -----------------------------------------------------------------------------
685 // The first line of the entry is the internal name. 718 // The first line of the entry is the internal name.
686 // 719 //
687 // To add a new entry, add to the end of kFeatureEntries. There are two 720 // To add a new entry, add to the end of kFeatureEntries. There are two
688 // distinct types of entries: 721 // distinct types of entries:
689 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE 722 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE
690 // macro for this type supplying the command line to the macro. 723 // macro for this type supplying the command line to the macro.
691 // . MULTI_VALUE: a list of choices, the first of which should correspond to a 724 // . MULTI_VALUE: a list of choices, the first of which should correspond to a
692 // deactivated state for this lab (i.e. no command line option). To specify 725 // deactivated state for this lab (i.e. no command line option). To specify
(...skipping 1469 matching lines...) Expand 10 before | Expand all | Expand 10 after
2162 #endif // defined(OS_CHROMEOS) 2195 #endif // defined(OS_CHROMEOS)
2163 2196
2164 #if defined(OS_ANDROID) 2197 #if defined(OS_ANDROID)
2165 {"enable-expanded-autofill-credit-card-popup", 2198 {"enable-expanded-autofill-credit-card-popup",
2166 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT, 2199 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT,
2167 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT_DESCRIPTION, 2200 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT_DESCRIPTION,
2168 kOsAndroid, FEATURE_WITH_VARIATIONS_VALUE_TYPE( 2201 kOsAndroid, FEATURE_WITH_VARIATIONS_VALUE_TYPE(
2169 autofill::kAutofillCreditCardPopupLayout, 2202 autofill::kAutofillCreditCardPopupLayout,
2170 kAutofillCreditCardPopupLayoutFeatureVariations, 2203 kAutofillCreditCardPopupLayoutFeatureVariations,
2171 "AutofillCreditCardPopupLayout")}, 2204 "AutofillCreditCardPopupLayout")},
2205 {"enable-autofill-credit-card-last-used-date-display",
2206 IDS_FLAGS_ENABLE_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_DISPLAY,
2207 IDS_FLAGS_ENABLE_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_DISPLAY_DESCRIPTION,
2208 kOsAndroid, FEATURE_WITH_VARIATIONS_VALUE_TYPE(
2209 autofill::kAutofillCreditCardLastUsedDateDisplay,
2210 kAutofillCreditCardLastUsedDateFeatureVariations,
2211 "AutofillCreditCardLastUsedDate")},
2172 {"native-android-history-manager", IDS_NATIVE_ANDROID_HISTORY_MANAGER, 2212 {"native-android-history-manager", IDS_NATIVE_ANDROID_HISTORY_MANAGER,
2173 IDS_NATIVE_ANDROID_HISTORY_MANAGER_DESCRIPTION, kOsAndroid, 2213 IDS_NATIVE_ANDROID_HISTORY_MANAGER_DESCRIPTION, kOsAndroid,
2174 FEATURE_VALUE_TYPE(chrome::android::kNativeAndroidHistoryManager)}, 2214 FEATURE_VALUE_TYPE(chrome::android::kNativeAndroidHistoryManager)},
2175 #endif // OS_ANDROID 2215 #endif // OS_ANDROID
2176 2216
2177 #if defined(OS_WIN) 2217 #if defined(OS_WIN)
2178 {"windows10-custom-titlebar", IDS_FLAGS_WINDOWS10_CUSTOM_TITLEBAR_NAME, 2218 {"windows10-custom-titlebar", IDS_FLAGS_WINDOWS10_CUSTOM_TITLEBAR_NAME,
2179 IDS_FLAGS_WINDOWS10_CUSTOM_TITLEBAR_DESCRIPTION, kOsWin, 2219 IDS_FLAGS_WINDOWS10_CUSTOM_TITLEBAR_DESCRIPTION, kOsWin,
2180 SINGLE_VALUE_TYPE(switches::kWindows10CustomTitlebar)}, 2220 SINGLE_VALUE_TYPE(switches::kWindows10CustomTitlebar)},
2181 #endif // OS_WIN 2221 #endif // OS_WIN
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
2411 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2451 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2412 2452
2413 const FeatureEntry* GetFeatureEntries(size_t* count) { 2453 const FeatureEntry* GetFeatureEntries(size_t* count) {
2414 *count = arraysize(kFeatureEntries); 2454 *count = arraysize(kFeatureEntries);
2415 return kFeatureEntries; 2455 return kFeatureEntries;
2416 } 2456 }
2417 2457
2418 } // namespace testing 2458 } // namespace testing
2419 2459
2420 } // namespace about_flags 2460 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698