Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2607043002: [Autofill] Credit Card Autofill Last Used Date Experiment (Closed)
Patch Set: Fixed conflicts Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 677 matching lines...) Expand 10 before | Expand all | Expand 10 after
688 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight, 688 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight,
689 arraysize( 689 arraysize(
690 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight), 690 kAutofillCreditCardPopupLayoutFeatureVariationDropdownItemHeight),
691 nullptr}, 691 nullptr},
692 {"Display credit card icon at start and increase dropdown item height", 692 {"Display credit card icon at start and increase dropdown item height",
693 kAutofillCreditCardPopupLayoutFeatureVariationExpanded, 693 kAutofillCreditCardPopupLayoutFeatureVariationExpanded,
694 arraysize(kAutofillCreditCardPopupLayoutFeatureVariationExpanded), 694 arraysize(kAutofillCreditCardPopupLayoutFeatureVariationExpanded),
695 nullptr}}; 695 nullptr}};
696 #endif // OS_ANDROID 696 #endif // OS_ANDROID
697 697
698 #if defined(OS_ANDROID)
699 const FeatureEntry::FeatureParam
700 kAutofillCreditCardLastUsedDateFeatureVariationExpDate[] = {
701 {"show_expiration_date", "true"}};
702
703 const FeatureEntry::FeatureParam
704 kAutofillCreditCardLastUsedDateFeatureVariationTimeDetail[] = {
705 {"show_time_detail", "true"}};
706
707 const FeatureEntry::FeatureParam
708 kAutofillCreditCardLastUsedDateFeatureVariationExpDateAndTimeDetail[] = {
709 {"show_expiration_date", "true"},
710 {"show_time_detail", "true"}};
711
712 const FeatureEntry::FeatureVariation
713 kAutofillCreditCardLastUsedDateFeatureVariations[] = {
714 {"Display expiration date",
715 kAutofillCreditCardLastUsedDateFeatureVariationExpDate,
716 arraysize(
717 kAutofillCreditCardLastUsedDateFeatureVariationExpDate),
718 nullptr},
719 {"Display time detail",
720 kAutofillCreditCardLastUsedDateFeatureVariationTimeDetail,
721 arraysize(
722 kAutofillCreditCardLastUsedDateFeatureVariationTimeDetail),
723 nullptr},
724 {"Display expiration date and time detail",
725 kAutofillCreditCardLastUsedDateFeatureVariationExpDateAndTimeDetail,
726 arraysize(
727 kAutofillCreditCardLastUsedDateFeatureVariationExpDateAndTimeDetail),
728 nullptr}};
729 #endif // OS_ANDROID
730
698 // RECORDING USER METRICS FOR FLAGS: 731 // RECORDING USER METRICS FOR FLAGS:
699 // ----------------------------------------------------------------------------- 732 // -----------------------------------------------------------------------------
700 // The first line of the entry is the internal name. 733 // The first line of the entry is the internal name.
701 // 734 //
702 // To add a new entry, add to the end of kFeatureEntries. There are two 735 // To add a new entry, add to the end of kFeatureEntries. There are two
703 // distinct types of entries: 736 // distinct types of entries:
704 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE 737 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE
705 // macro for this type supplying the command line to the macro. 738 // macro for this type supplying the command line to the macro.
706 // . MULTI_VALUE: a list of choices, the first of which should correspond to a 739 // . MULTI_VALUE: a list of choices, the first of which should correspond to a
707 // deactivated state for this lab (i.e. no command line option). To specify 740 // deactivated state for this lab (i.e. no command line option). To specify
(...skipping 1480 matching lines...) Expand 10 before | Expand all | Expand 10 after
2188 #endif // defined(OS_CHROMEOS) 2221 #endif // defined(OS_CHROMEOS)
2189 2222
2190 #if defined(OS_ANDROID) 2223 #if defined(OS_ANDROID)
2191 {"enable-expanded-autofill-credit-card-popup", 2224 {"enable-expanded-autofill-credit-card-popup",
2192 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT, 2225 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT,
2193 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT_DESCRIPTION, 2226 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT_DESCRIPTION,
2194 kOsAndroid, FEATURE_WITH_VARIATIONS_VALUE_TYPE( 2227 kOsAndroid, FEATURE_WITH_VARIATIONS_VALUE_TYPE(
2195 autofill::kAutofillCreditCardPopupLayout, 2228 autofill::kAutofillCreditCardPopupLayout,
2196 kAutofillCreditCardPopupLayoutFeatureVariations, 2229 kAutofillCreditCardPopupLayoutFeatureVariations,
2197 "AutofillCreditCardPopupLayout")}, 2230 "AutofillCreditCardPopupLayout")},
2231 {"enable-autofill-credit-card-last-used-date-display",
2232 IDS_FLAGS_ENABLE_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_DISPLAY,
2233 IDS_FLAGS_ENABLE_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_DISPLAY_DESCRIPTION,
2234 kOsAndroid, FEATURE_WITH_VARIATIONS_VALUE_TYPE(
2235 autofill::kAutofillCreditCardLastUsedDateDisplay,
2236 kAutofillCreditCardLastUsedDateFeatureVariations,
2237 "AutofillCreditCardLastUsedDate")},
2198 {"native-android-history-manager", IDS_NATIVE_ANDROID_HISTORY_MANAGER, 2238 {"native-android-history-manager", IDS_NATIVE_ANDROID_HISTORY_MANAGER,
2199 IDS_NATIVE_ANDROID_HISTORY_MANAGER_DESCRIPTION, kOsAndroid, 2239 IDS_NATIVE_ANDROID_HISTORY_MANAGER_DESCRIPTION, kOsAndroid,
2200 FEATURE_VALUE_TYPE(chrome::android::kNativeAndroidHistoryManager)}, 2240 FEATURE_VALUE_TYPE(chrome::android::kNativeAndroidHistoryManager)},
2201 #endif // OS_ANDROID 2241 #endif // OS_ANDROID
2202 {"enable-faster-location-reload", IDS_FLAGS_FASTER_LOCATION_RELOAD_NAME, 2242 {"enable-faster-location-reload", IDS_FLAGS_FASTER_LOCATION_RELOAD_NAME,
2203 IDS_FLAGS_FASTER_LOCATION_RELOAD_DESCRIPTION, kOsAll, 2243 IDS_FLAGS_FASTER_LOCATION_RELOAD_DESCRIPTION, kOsAll,
2204 FEATURE_VALUE_TYPE(features::kFasterLocationReload)}, 2244 FEATURE_VALUE_TYPE(features::kFasterLocationReload)},
2205 #if defined(OS_ANDROID) 2245 #if defined(OS_ANDROID)
2206 {"lsd-permission-prompt", IDS_FLAGS_LSD_PERMISSION_PROMPT_NAME, 2246 {"lsd-permission-prompt", IDS_FLAGS_LSD_PERMISSION_PROMPT_NAME,
2207 IDS_FLAGS_LSD_PERMISSION_PROMPT_DESCRIPTION, kOsAndroid, 2247 IDS_FLAGS_LSD_PERMISSION_PROMPT_DESCRIPTION, kOsAndroid,
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
2420 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2460 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2421 2461
2422 const FeatureEntry* GetFeatureEntries(size_t* count) { 2462 const FeatureEntry* GetFeatureEntries(size_t* count) {
2423 *count = arraysize(kFeatureEntries); 2463 *count = arraysize(kFeatureEntries);
2424 return kFeatureEntries; 2464 return kFeatureEntries;
2425 } 2465 }
2426 2466
2427 } // namespace testing 2467 } // namespace testing
2428 2468
2429 } // namespace about_flags 2469 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698