[Autofill] Credit Card Autofill Last Used Date Experiment

components/autofill/core/browser/personal_data_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <list>
@@ skipping 3388 matching lines @@
   types.push_back(ADDRESS_HOME_CITY);
   types.push_back(ADDRESS_HOME_STATE);
   std::vector<Suggestion> suggestions = personal_data_->GetProfileSuggestions(
       AutofillType(ADDRESS_HOME_STREET_ADDRESS), base::ASCIIToUTF16("123"),
       false, types);
   ASSERT_EQ(2U, suggestions.size());
   EXPECT_EQ(base::ASCIIToUTF16("Hollywood, CA"), suggestions[0].label);
   EXPECT_EQ(base::ASCIIToUTF16("Hollywood, TX"), suggestions[1].label);
 }
 
-// Tests that GetProfileSuggestions orders its suggestions based on the frecency
-// formula.
+// Tests that GetProfileSuggestions orders its suggestions based on the
+// frequency formula.
 TEST_F(PersonalDataManagerTest, GetProfileSuggestions_Ranking) {
   // Set up the profiles. They are named with number suffixes X so the X is the
-  // order in which they should be ordered by frecency.
+  // order in which they should be ordered by frequency.
   AutofillProfile profile3(base::GenerateGUID(), "https://www.example.com");
   test::SetProfileInfo(&profile3, "Marion3", "Mitchell", "Morrison",
                        "johnwayne@me.xyz", "Fox",
                        "123 Zoo St.\nSecond Line\nThird line", "unit 5",
                        "Hollywood", "CA", "91601", "US", "12345678910");
   profile3.set_use_date(base::Time::Now() - base::TimeDelta::FromDays(1));
   profile3.set_use_count(5);
   personal_data_->AddProfile(profile3);
 
   AutofillProfile profile1(base::GenerateGUID(), "https://www.example.com");
@@ skipping 183 matching lines @@
   ASSERT_EQ(5U, suggestions.size());
 
   // All cards should be ordered as expected.
   EXPECT_EQ(ASCIIToUTF16("Jesse James"), suggestions[0].value);
   EXPECT_EQ(ASCIIToUTF16("John Dillinger"), suggestions[1].value);
   EXPECT_EQ(ASCIIToUTF16("Clyde Barrow"), suggestions[2].value);
   EXPECT_EQ(ASCIIToUTF16("Emmet Dalton"), suggestions[3].value);
   EXPECT_EQ(ASCIIToUTF16("Bonnie Parker"), suggestions[4].value);
 }
 
-// Test that expired cards are ordered by frecency and are always suggested
-// after non expired cards even if they have a higher frecency score.
+// Test that expired cards are ordered by frequency and are always suggested
+// after non expired cards even if they have a higher frequency score.
 TEST_F(PersonalDataManagerTest, GetCreditCardSuggestions_ExpiredCards) {
   ASSERT_EQ(0U, personal_data_->GetCreditCards().size());
 
   // Add a never used non expired credit card.
   CreditCard credit_card0("002149C1-EE28-4213-A3B9-DA243FFF021B",
                           "https://www.example.com");
   test::SetCreditCardInfo(&credit_card0, "Bonnie Parker",
                           "518765432109" /* Mastercard */, "04", "2999");
   personal_data_->AddCreditCard(credit_card0);
 
-  // Add an expired card with a higher frecency score.
+  // Add an expired card with a higher frequency score.
   CreditCard credit_card1("287151C8-6AB1-487C-9095-28E80BE5DA15",
                           "https://www.example.com");
   test::SetCreditCardInfo(&credit_card1, "Clyde Barrow",
                           "347666888555" /* American Express */, "04", "1999");
   credit_card1.set_use_count(300);
   credit_card1.set_use_date(base::Time::Now() - base::TimeDelta::FromDays(10));
   personal_data_->AddCreditCard(credit_card1);
 
-  // Add an expired card with a lower frecency score.
+  // Add an expired card with a lower frequency score.
   CreditCard credit_card2("1141084B-72D7-4B73-90CF-3D6AC154673B",
                           "https://www.example.com");
   credit_card2.set_use_count(3);
   credit_card2.set_use_date(base::Time::Now() - base::TimeDelta::FromDays(1));
   test::SetCreditCardInfo(&credit_card2, "John Dillinger",
                           "423456789012" /* Visa */, "01", "1998");
   personal_data_->AddCreditCard(credit_card2);
 
   EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
       .WillOnce(QuitMainMessageLoop());
   base::RunLoop().Run();
 
   ASSERT_EQ(3U, personal_data_->GetCreditCards().size());
 
   std::vector<Suggestion> suggestions =
       personal_data_->GetCreditCardSuggestions(
           AutofillType(CREDIT_CARD_NAME_FULL),
           /* field_contents= */ base::string16());
   ASSERT_EQ(3U, suggestions.size());
 
   // The never used non expired card should be suggested first.
   EXPECT_EQ(ASCIIToUTF16("Bonnie Parker"), suggestions[0].value);
 
-  // The expired cards should be sorted by frecency
+  // The expired cards should be sorted by frequency
   EXPECT_EQ(ASCIIToUTF16("Clyde Barrow"), suggestions[1].value);
   EXPECT_EQ(ASCIIToUTF16("John Dillinger"), suggestions[2].value);
 }
 
 // Test that a card that doesn't have a number is not shown in the suggestions
 // when querying credit cards by their number.
 TEST_F(PersonalDataManagerTest, GetCreditCardSuggestions_NumberMissing) {
   // Create one normal credit card and one credit card with the number missing.
   ASSERT_EQ(0U, personal_data_->GetCreditCards().size());
 
@@ skipping 134 matching lines @@
   EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
       .WillOnce(QuitMainMessageLoop());
   base::RunLoop().Run();
 
   suggestions = personal_data_->GetCreditCardSuggestions(
       AutofillType(CREDIT_CARD_NAME_FULL),
       /* field_contents= */ base::string16());
   ASSERT_EQ(3U, suggestions.size());
 }
 
+// Tests that credit card last used date suggestion can be generated correctly
+// in different variations and locales
+
 // Tests that only the full server card is kept when deduping with a local
 // duplicate of it.
 TEST_F(PersonalDataManagerTest,
        DedupeCreditCardToSuggest_FullServerShadowsLocal) {
   std::list<CreditCard*> credit_cards;
 
   // Create 3 different local credit cards.
   CreditCard local_card("287151C8-6AB1-487C-9095-28E80BE5DA15",
                         "https://www.example.com");
   test::SetCreditCardInfo(&local_card, "Homer Simpson",
@@ skipping 1812 matching lines @@
   EnableAutofillProfileCleanup();
 
   // The deduping routine should not be run.
   EXPECT_FALSE(personal_data_->ApplyDedupingRoutine());
 
   // The two duplicate profiles should still be present.
   EXPECT_EQ(2U, personal_data_->GetProfiles().size());
 }
 
 }  // namespace autofill