[Autofill] Credit Card Autofill Last Used Date Experiment

components/autofill/core/browser/personal_data_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <list>
@@ skipping 1615 matching lines @@
       suggestion->backend_id = credit_card->guid();
       suggestion->match = prefix_matched_suggestion
                               ? Suggestion::PREFIX_MATCH
                               : Suggestion::SUBSTRING_MATCH;
 
       // If the value is the card number, the label is the expiration date.
       // Otherwise the label is the card number, or if that is empty the
       // cardholder name. The label should never repeat the value.
       if (type.GetStorableType() == CREDIT_CARD_NUMBER) {
         suggestion->value = credit_card->TypeAndLastFourDigits();
-        suggestion->label = credit_card->GetInfo(
-            AutofillType(CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR), app_locale_);
+        if (IsAutofillCreditCardLastUsedDateDisplayExperimentEnabled() &&
+            !IsKeyboardAccessoryEnabled()) {
+          if (ShowExpirationDateInAutofillCreditCardLastUsedDate()) {
+            suggestion->label = credit_card->GetInfo(
+                AutofillType(CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR), app_locale_);
+          }
+          if (suggestion->label.empty()) {
+            suggestion->label = credit_card->GetLastUsedDateForDisplay(
+                ShowExpirationDateInAutofillCreditCardLastUsedDate(),
+                ShowTimeDetailInAutofillCreditCardLastUsedDate());
+          } else {
+            suggestion->label.append(credit_card->GetLastUsedDateForDisplay(
+                ShowExpirationDateInAutofillCreditCardLastUsedDate(),
+                ShowTimeDetailInAutofillCreditCardLastUsedDate()));

[jungshik at Google, 2017/01/23 21:43:24]

This kind of concatenating strings (Exp. date + LastTimeUsed) is not a good
idea. There are 4 combinations and you'd better have 4 messages (added to a
grd(p) file). 

1. Exp. date: 04/20, last used Dec 10 at 11:35
2. Last used Dec 10 at 11:35
3. Exp. date: 04/20, last used on Dec 10
4. Last used on Dec 10. 

[jiahuiguo, 2017/01/26 05:46:13]

Done.

+          }
+        } else {
+          suggestion->label = credit_card->GetInfo(
+              AutofillType(CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR), app_locale_);
+        }
         if (IsAutofillCreditCardPopupLayoutExperimentEnabled())
           ModifyAutofillCreditCardSuggestion(suggestion);
       } else if (credit_card->number().empty()) {
         if (type.GetStorableType() != CREDIT_CARD_NAME_FULL) {
           suggestion->label = credit_card->GetInfo(
               AutofillType(CREDIT_CARD_NAME_FULL), app_locale_);
         }
       } else {
 #if defined(OS_ANDROID)
         // Since Android places the label on its own row, there's more
@@ skipping 213 matching lines @@
     }
 
     // If the card was modified, apply the changes to the database.
     if (was_modified) {
       database_->UpdateCreditCard(*credit_card);
     }
   }
 }
 
 }  // namespace autofill