[Autofill] Credit Card Autofill Last Used Date Experiment

components/autofill/core/browser/credit_card.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/credit_card.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <ostream>
 #include <string>
 
 #include "base/guid.h"
+#include "base/i18n/time_formatting.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
@@ skipping 56 matching lines @@
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_UNION_PAY);
   if (type == kVisaCard)
     return l10n_util::GetStringUTF16(IDS_AUTOFILL_CC_VISA);
 
   // If you hit this DCHECK, the above list of cases needs to be updated to
   // include a new card.
   DCHECK_EQ(kGenericCard, type);
   return base::string16();
 }
 
+// Padding month and day info to exactly 2 digits.
+base::string16 PadTo2Digit(int32_t date_info) {
+  DCHECK(date_info > 0);
+  base::string16 date_in_2_digits = base::IntToString16(date_info);
+  if (date_info >= 10)
+    return date_in_2_digits;
+
+  base::string16 padded_date = ASCIIToUTF16("0");
+  padded_date.append(date_in_2_digits);
+  return padded_date;

[jungshik at Google, 2017/01/23 21:43:24]

Some locales do NOT use ASCII digit. So that prepending with '0' 
does not work. 

Why don't you just use TimeFormatWithPattern(time, 'MMdd')? Well, you have to
make up a 'time' corresponding to the expiration date to pass, but it'd be a
small cost to pay for the locale-aware formatting.  

[jiahuiguo, 2017/01/26 05:46:12]

Thanks for pointing this out, for the expiration date shown on a credit card, it
is ISO standard to format as "MM/YY" or "MM-YY", where the former is prefered,
so constructing such a string would be ok for different locales?

Actually the way to padding the month is from the original code, and it was used
in several places, if it is fundamentally wrong, I can fill a bug and fix it in
a following CL.  

+}
+
 }  // namespace
 
 CreditCard::CreditCard(const std::string& guid, const std::string& origin)
     : AutofillDataModel(guid, origin),
       record_type_(LOCAL_CARD),
       type_(kGenericCard),
       expiration_month_(0),
       expiration_year_(0),
       server_status_(OK) {}
 
@@ skipping 569 matching lines @@
   supported_types->insert(CREDIT_CARD_NUMBER);
   supported_types->insert(CREDIT_CARD_TYPE);
   supported_types->insert(CREDIT_CARD_EXP_MONTH);
   supported_types->insert(CREDIT_CARD_EXP_2_DIGIT_YEAR);
   supported_types->insert(CREDIT_CARD_EXP_4_DIGIT_YEAR);
   supported_types->insert(CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR);
   supported_types->insert(CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR);
 }
 
 base::string16 CreditCard::ExpirationMonthAsString() const {
-  if (expiration_month_ == 0)
-    return base::string16();
-
-  base::string16 month = base::IntToString16(expiration_month_);
-  if (expiration_month_ >= 10)
-    return month;
-
-  base::string16 zero = ASCIIToUTF16("0");
-  zero.append(month);
-  return zero;
+  return expiration_month_ == 0
+      ? base::string16()
+      : PadTo2Digit(expiration_month_);
 }
 
 base::string16 CreditCard::TypeForFill() const {
   return ::autofill::TypeForFill(type_);
 }
 
 base::string16 CreditCard::Expiration4DigitYearAsString() const {
   if (expiration_year_ == 0)
     return base::string16();
 
@@ skipping 76 matching lines @@
 
 void CreditCard::SetNumber(const base::string16& number) {
   number_ = number;
 
   // Set the type based on the card number, but only for full numbers, not
   // when we have masked cards from the server (last 4 digits).
   if (record_type_ != MASKED_SERVER_CARD)
     type_ = GetCreditCardType(StripSeparators(number_));
 }
 
+base::string16 CreditCard::GetLastUsedDateForDisplay(
+    bool show_expiration_date,
+    bool show_time_detail) const {
+  DCHECK(use_count() > 0);
+  // use_count() is initialized as 1 when the card is just added.
+  if (use_count() == 1) {
+    return l10n_util::GetStringFUTF16(
+        show_expiration_date
+            ? IDS_AUTOFILL_CREDIT_CARD_ADDED_DATE_LABEL_AND_EXP
+            : IDS_AUTOFILL_CREDIT_CARD_ADDED_DATE_LABEL,
+        base::TimeFormatWithPattern(use_date(), "MMMdd"));
+  }
+  // use_count() > 1 when the card has been used in autofill.
+  if (show_time_detail) {
+    return l10n_util::GetStringFUTF16(
+        show_expiration_date
+            ? IDS_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_LABEL_AND_EXP_WITH_DETAIL
+            : IDS_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_LABEL_WITH_DETAIL,
+        base::TimeFormatWithPattern(use_date(), "MMMddjmm"));
+  } else {
+    return l10n_util::GetStringFUTF16(
+        show_expiration_date
+            ? IDS_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_LABEL_AND_EXP_NO_DETAIL
+            : IDS_AUTOFILL_CREDIT_CARD_LAST_USED_DATE_LABEL_NO_DETAIL,
+        base::TimeFormatWithPattern(use_date(), "MMMdd"));

[jungshik at Google, 2017/01/23 21:43:24]

There are 4 combinations here and they're combined with 

[jiahuiguo, 2017/01/26 05:46:12]

Done.

+  }
+}
+
 void CreditCard::RecordAndLogUse() {
   UMA_HISTOGRAM_COUNTS_1000("Autofill.DaysSinceLastUse.CreditCard",
                             (base::Time::Now() - use_date()).InDays());
   RecordUse();
 }
 
 // static
 bool CreditCard::ConvertMonth(const base::string16& month,
                               const std::string& app_locale,
                               int* num) {
@@ skipping 76 matching lines @@
 const char kDinersCard[] = "dinersCC";
 const char kDiscoverCard[] = "discoverCC";
 const char kGenericCard[] = "genericCC";
 const char kJCBCard[] = "jcbCC";
 const char kMasterCard[] = "masterCardCC";
 const char kMirCard[] = "mirCC";
 const char kUnionPay[] = "unionPayCC";
 const char kVisaCard[] = "visaCC";
 
 }  // namespace autofill