Some constructor fixes: implement redirecting constructors, work with finding default constructors …

Some constructor quick fixes: implement redirecting constructors, work with finding default constructors (!).

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9b7247e071c562d4aff539b3f257e7415cf29189

[Emily Fortuna, 2016-12-29 23:03:05]

Description was changed from

==========
Some constructor fixes: implement redirecting constructors, work with finding
default constructors (!).

BUG=
==========

to

==========
Some constructor quick fixes: implement redirecting constructors, work with
finding default constructors (!).

BUG=
==========

[Emily Fortuna, 2016-12-29 23:03:06]

efortuna@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-12-29 23:28:33]

lgtm

https://codereview.chromium.org/2607013003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2607013003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:319:
_buildInlinedSuperInitializers(
I wonder if we should rename this function. Some ideas:
 - _buildInlinedSuperOrRedirectInitializers (yikes!), or
 - _buildInlinedXYZInitializer where XYZ can be "direct", "special", "known", or
simply
 - _buildInlinedInitializer
?

https://codereview.chromium.org/2607013003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:330: if (!foundSuperOrRedirectCall)
{
consider updating the comment above this?

I believe that the redirect will handle injecting a default super call
transitively as well, but just wanted to double check. For example, in a code
like:

class A {
  final x;
  @NoInline()
  A() : x = 1;
}

class B extends A {
  final y;

  @NoInline()
  B.a(v) : y = v;

  @NoInline()
  B.b() : this.a(2);
}


I expect that the code for `B.b()` should include the x = 1 initializer,
correct?

[Emily Fortuna, 2016-12-29 23:42:44]

https://codereview.chromium.org/2607013003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2607013003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:319:
_buildInlinedSuperInitializers(
On 2016/12/29 23:28:33, Siggi Cherem (dart-lang) wrote:
> I wonder if we should rename this function. Some ideas:
>  - _buildInlinedSuperOrRedirectInitializers (yikes!), or
>  - _buildInlinedXYZInitializer where XYZ can be "direct", "special", "known",
or
> simply
>  - _buildInlinedInitializer
> ?

good point. I changed to _buildInlinedInitializer

https://codereview.chromium.org/2607013003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:330: if (!foundSuperOrRedirectCall)
{
On 2016/12/29 23:28:32, Siggi Cherem (dart-lang) wrote:
> consider updating the comment above this?
> 
> I believe that the redirect will handle injecting a default super call
> transitively as well, but just wanted to double check. For example, in a code
> like:
> 
> class A {
>   final x;
>   @NoInline()
>   A() : x = 1;
> }
> 
> class B extends A {
>   final y;
> 
>   @NoInline()
>   B.a(v) : y = v;
> 
>   @NoInline()
>   B.b() : this.a(2);
> }
> 
> 
> I expect that the code for `B.b()` should include the x = 1 initializer,
> correct?
> 
> 

Correct. and good catch on the comment. updated!

[Emily Fortuna, 2016-12-29 23:43:26]

Description was changed from

==========
Some constructor quick fixes: implement redirecting constructors, work with
finding default constructors (!).

BUG=
==========

to

==========
Some constructor quick fixes: implement redirecting constructors, work with
finding default constructors (!).

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9b7247e071c562d4aff539b3f257e7415cf29189
==========

[Emily Fortuna, 2016-12-29 23:43:27]

Committed patchset #3 (id:40001) manually as
9b7247e071c562d4aff539b3f257e7415cf29189 (presubmit successful).