Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py

Issue 2607013002: Simplify platform specifier list added by w3c-test-autoroller. (Closed)
Patch Set: Rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py
index e3c1409db7f5dd759e633706e143636d501ac999..bb200c2adf516eb4b4f6b85c91e0bf090aa307d1 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py
@@ -137,6 +137,18 @@ class UpdateW3CTestExpectationsTest(LoggingTestCase):
'crbug.com/test [ one ] external/fake/test/path.html [ Pass ]',
])
+ def test_create_line_list_all_platforms(self):
+ platforms = ('Trusty', 'Mac10.11', 'Mac10.10', 'Retina', 'Win7', 'Win10', 'Mac10.9')
+ results = {
+ 'imported/fake/test/path.html': {
+ platforms: {'expected': 'PASS', 'actual': 'CRASH', 'bug': 'crbug.com/test'},
+ }
+ }
+ line_adder = W3CExpectationsLineAdder(self.host)
+ self.assertEqual(
+ line_adder.create_line_list(results),
+ ['crbug.com/test [ Mac10.10 Mac10.11 Mac10.9 Retina Trusty Win10 Win7 ] imported/fake/test/path.html [ Crash ]'])
+
def test_merge_dicts_with_conflict_raise_exception(self):
line_adder = W3CExpectationsLineAdder(self.host)
# Both dicts here have the key "one", and the value is not equal.
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698