Second try: Fix resolution and canonicalization of typedefs and function types

Second try: Fix resolution and canonicalization of typedefs and function types
in preparation of the new typedef syntax.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/3334c2402a8f2b0372f6a81af493dda853a33d2b

[regis, 2016-12-28 22:12:17]

regis@google.com changed reviewers:
+ asiva@google.com

[regis, 2016-12-28 22:12:19]

This is the second commit attempt after this cl was reverted:
https://codereview.chromium.org/2592263004/

See the embedded comments showing the 3 things that were fixed since the cl
above.

https://codereview.chromium.org/2606993002/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (left):

https://codereview.chromium.org/2606993002/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:4012:
signature_function.SetSignatureType(signature_type);
This statement was setting the signature type on the replaced signature
function, triggering an assert.

https://codereview.chromium.org/2606993002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2606993002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:12035: if (type.HasResolvedTypeClass()) {
This ResolveType function may be called with finalization ==
ClassFinalizer::kResolveTypeParameters, in which case the type class is not yet
resolved at this point. The class finalizer will resolve and check it later.

https://codereview.chromium.org/2606993002/diff/1/tests/lib/lib.status
File tests/lib/lib.status (left):

https://codereview.chromium.org/2606993002/diff/1/tests/lib/lib.status#oldcod...
tests/lib/lib.status:429: mirrors/typedef_reflected_type_test/01: Fail # Type
equality - Issue 26869
This test now passes.

[siva, 2016-12-28 22:52:30]

lgtm

[regis, 2016-12-28 22:53:29]

Description was changed from

==========
Second try: Fix resolution and canonicalization of typedefs and function types
in preparation of the new typedef syntax.
==========

to

==========
Second try: Fix resolution and canonicalization of typedefs and function types
in preparation of the new typedef syntax.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3334c2402a8f2b0372f6a81af493dda853a33d2b
==========

[regis, 2016-12-28 22:53:30]

Committed patchset #1 (id:1) manually as
3334c2402a8f2b0372f6a81af493dda853a33d2b (presubmit successful).