ios/chrome/browser/tabs/tab.h - Issue 2606873002: Move the offline URL trimming to GetFormattedURL.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/tabs/tab.h

Issue 2606873002: Move the offline URL trimming to GetFormattedURL. (Closed)

Patch Set: clean Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/reading_list/offline_url_utils_unittest.cc ('K') | « ios/chrome/browser/reading_list/offline_url_utils_unittest.cc ('k') | ios/chrome/browser/tabs/tab.mm » ('j') | ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_CHROME_BROWSER_TABS_TAB_H_	5 #ifndef IOS_CHROME_BROWSER_TABS_TAB_H_

6 #define IOS_CHROME_BROWSER_TABS_TAB_H_	6 #define IOS_CHROME_BROWSER_TABS_TAB_H_

7	7

8 #import <UIKit/UIKit.h>	8 #import <UIKit/UIKit.h>

9	9

10 #include <memory>	10 #include <memory>

(...skipping 331 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
342	342

343 // Called when this tab is shown.	343 // Called when this tab is shown.

344 - (void)wasShown;	344 - (void)wasShown;

345	345

346 // Called when this tab is hidden.	346 // Called when this tab is hidden.

347 - (void)wasHidden;	347 - (void)wasHidden;

348	348

349 // Evaluates U2F result.	349 // Evaluates U2F result.

350 - (void)evaluateU2FResultFromURL:(const GURL&)url;	350 - (void)evaluateU2FResultFromURL:(const GURL&)url;

351	351

	352 // Returns whether the tab is currently displaying an offline page.

	353 - (BOOL)isOffline;
	Eugene But (OOO till 7-30) 2016/12/28 17:02:59 Should this be a property, like isLinkLoadingPrere Should this be a property, like isLinkLoadingPrerenderTab/isVoiceSearchResultsTab: @property(nonatomic, readonly, getter=isOffline) BOOL offline; But I guess the bigger question is: "Should we even add anything to Tab, because this class should be removed?". Olivier 2016/12/29 12:37:20 Removed Show quoted text On 2016/12/28 17:02:59, Eugene But wrote: > Should this be a property, like > isLinkLoadingPrerenderTab/isVoiceSearchResultsTab: > @property(nonatomic, readonly, getter=isOffline) BOOL offline; > > But I guess the bigger question is: "Should we even add anything to Tab, because > this class should be removed?". Removed
	354

352 @end	355 @end

353	356

354 #endif // IOS_CHROME_BROWSER_TABS_TAB_H_	357 #endif // IOS_CHROME_BROWSER_TABS_TAB_H_

OLD	NEW