Move the offline URL trimming to GetFormattedURL.

ios/chrome/browser/reading_list/offline_url_utils_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/reading_list/offline_url_utils.h"
 
 #include <string>
 
 #include "base/files/file_path.h"
+#include "base/strings/utf_string_conversions.h"
+#include "base/test/gtest_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 // Checks the distilled URL for the page is chrome://offline/MD5/page.html;
 TEST(OfflineURLUtilsTest, DistilledURLForPathTest) {
   base::FilePath page_path("MD5/page.html");
   GURL distilled_url = reading_list::DistilledURLForPath(page_path, GURL());
   EXPECT_EQ("chrome://offline/MD5/page.html", distilled_url.spec());
 }
 
@@ skipping 53 matching lines @@
   EXPECT_FALSE(reading_list::IsOfflineURL(GURL("chrome://")));
   EXPECT_FALSE(reading_list::IsOfflineURL(GURL("chrome://offline-foobar")));
   EXPECT_FALSE(reading_list::IsOfflineURL(GURL("http://offline/")));
   EXPECT_FALSE(reading_list::IsOfflineURL(GURL("http://chrome://offline/")));
   EXPECT_TRUE(reading_list::IsOfflineURL(GURL("chrome://offline")));
   EXPECT_TRUE(reading_list::IsOfflineURL(GURL("chrome://offline/")));
   EXPECT_TRUE(reading_list::IsOfflineURL(GURL("chrome://offline/foobar")));
   EXPECT_TRUE(
       reading_list::IsOfflineURL(GURL("chrome://offline/foobar?foo=bar")));
 }
+
+TEST(OfflineURLUtilsTest, StripSchemeFromOnlineUrlTest) {

[Eugene But (OOO till 7-30), 2016/12/28 17:02:59]

Could you please add comments for test method.

[Olivier, 2016/12/29 12:37:20]

Done.

+  base::string16 empty_url = base::UTF8ToUTF16("");

[Eugene But (OOO till 7-30), 2016/12/28 17:02:59]

Should this be just |base::string16 empty_url;|?

[Olivier, 2016/12/29 12:37:20]

Done.

+  EXPECT_EQ(reading_list::StripSchemeFromOnlineUrl(empty_url), empty_url);
+  base::string16 https_url = base::UTF8ToUTF16("https://www.chromium.org/");
+  base::string16 trimmed_https_url = base::UTF8ToUTF16("www.chromium.org/");
+  EXPECT_EQ(reading_list::StripSchemeFromOnlineUrl(https_url),
+            trimmed_https_url);
+  base::string16 http_url = base::UTF8ToUTF16("http://www.chromium.org/");
+  EXPECT_DCHECK_DEATH(reading_list::StripSchemeFromOnlineUrl(http_url));
+  base::string16 other_scheme_url =
+      base::UTF8ToUTF16("scheme://www.chromium.org/");
+  EXPECT_EQ(reading_list::StripSchemeFromOnlineUrl(other_scheme_url),
+            other_scheme_url);
+  base::string16 no_scheme_url = base::UTF8ToUTF16("www.chromium.org/");
+  EXPECT_EQ(reading_list::StripSchemeFromOnlineUrl(no_scheme_url),
+            no_scheme_url);
+}