src/full-codegen/ia32/full-codegen-ia32.cc - Issue 2606833002: [ESnext] Implement Object spread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2606833002: [ESnext] Implement Object spread (Closed)

Patch Set: fix test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 568db17ed27c77422dc42dec2e67c27a926742ff..6a046f3cdf86e9ecf0c12682987a68e0dbb0c381 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -1173,6 +1173,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

result_saved = true;

}

switch (property->kind()) {

+ case ObjectLiteral::Property::SPREAD:

case ObjectLiteral::Property::CONSTANT:

UNREACHABLE();

case ObjectLiteral::Property::MATERIALIZED_LITERAL: