Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 2606833002: [ESnext] Implement Object spread (Closed)
Patch Set: fix build Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1221 matching lines...) Expand 10 before | Expand all | Expand 10 after
1232 DCHECK(!property->is_computed_name()); 1232 DCHECK(!property->is_computed_name());
1233 if (property->IsCompileTimeValue()) continue; 1233 if (property->IsCompileTimeValue()) continue;
1234 1234
1235 Literal* key = property->key()->AsLiteral(); 1235 Literal* key = property->key()->AsLiteral();
1236 Expression* value = property->value(); 1236 Expression* value = property->value();
1237 if (!result_saved) { 1237 if (!result_saved) {
1238 PushOperand(v0); // Save result on stack. 1238 PushOperand(v0); // Save result on stack.
1239 result_saved = true; 1239 result_saved = true;
1240 } 1240 }
1241 switch (property->kind()) { 1241 switch (property->kind()) {
1242 case ObjectLiteral::Property::SPREAD:
1242 case ObjectLiteral::Property::CONSTANT: 1243 case ObjectLiteral::Property::CONSTANT:
1243 UNREACHABLE(); 1244 UNREACHABLE();
1244 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1245 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1245 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1246 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1246 // Fall through. 1247 // Fall through.
1247 case ObjectLiteral::Property::COMPUTED: 1248 case ObjectLiteral::Property::COMPUTED:
1248 // It is safe to use [[Put]] here because the boilerplate already 1249 // It is safe to use [[Put]] here because the boilerplate already
1249 // contains computed properties with an uninitialized value. 1250 // contains computed properties with an uninitialized value.
1250 if (key->IsStringLiteral()) { 1251 if (key->IsStringLiteral()) {
1251 DCHECK(key->IsPropertyName()); 1252 DCHECK(key->IsPropertyName());
(...skipping 1635 matching lines...) Expand 10 before | Expand all | Expand 10 after
2887 reinterpret_cast<uint64_t>( 2888 reinterpret_cast<uint64_t>(
2888 isolate->builtins()->OnStackReplacement()->entry())); 2889 isolate->builtins()->OnStackReplacement()->entry()));
2889 return ON_STACK_REPLACEMENT; 2890 return ON_STACK_REPLACEMENT;
2890 } 2891 }
2891 2892
2892 2893
2893 } // namespace internal 2894 } // namespace internal
2894 } // namespace v8 2895 } // namespace v8
2895 2896
2896 #endif // V8_TARGET_ARCH_MIPS64 2897 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698