Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2606833002: [ESnext] Implement Object spread (Closed)
Patch Set: fix build Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1219 matching lines...) Expand 10 before | Expand all | Expand 10 after
1230 DCHECK(!property->is_computed_name()); 1230 DCHECK(!property->is_computed_name());
1231 if (property->IsCompileTimeValue()) continue; 1231 if (property->IsCompileTimeValue()) continue;
1232 1232
1233 Literal* key = property->key()->AsLiteral(); 1233 Literal* key = property->key()->AsLiteral();
1234 Expression* value = property->value(); 1234 Expression* value = property->value();
1235 if (!result_saved) { 1235 if (!result_saved) {
1236 PushOperand(v0); // Save result on stack. 1236 PushOperand(v0); // Save result on stack.
1237 result_saved = true; 1237 result_saved = true;
1238 } 1238 }
1239 switch (property->kind()) { 1239 switch (property->kind()) {
1240 case ObjectLiteral::Property::SPREAD:
1240 case ObjectLiteral::Property::CONSTANT: 1241 case ObjectLiteral::Property::CONSTANT:
1241 UNREACHABLE(); 1242 UNREACHABLE();
1242 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1243 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1243 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1244 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1244 // Fall through. 1245 // Fall through.
1245 case ObjectLiteral::Property::COMPUTED: 1246 case ObjectLiteral::Property::COMPUTED:
1246 // It is safe to use [[Put]] here because the boilerplate already 1247 // It is safe to use [[Put]] here because the boilerplate already
1247 // contains computed properties with an uninitialized value. 1248 // contains computed properties with an uninitialized value.
1248 if (key->IsStringLiteral()) { 1249 if (key->IsStringLiteral()) {
1249 DCHECK(key->IsPropertyName()); 1250 DCHECK(key->IsPropertyName());
(...skipping 1628 matching lines...) Expand 10 before | Expand all | Expand 10 after
2878 reinterpret_cast<uint32_t>( 2879 reinterpret_cast<uint32_t>(
2879 isolate->builtins()->OnStackReplacement()->entry())); 2880 isolate->builtins()->OnStackReplacement()->entry()));
2880 return ON_STACK_REPLACEMENT; 2881 return ON_STACK_REPLACEMENT;
2881 } 2882 }
2882 2883
2883 2884
2884 } // namespace internal 2885 } // namespace internal
2885 } // namespace v8 2886 } // namespace v8
2886 2887
2887 #endif // V8_TARGET_ARCH_MIPS 2888 #endif // V8_TARGET_ARCH_MIPS
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698