Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: device/bluetooth/bluetooth_device_android.cc

Issue 2606823002: Remove base::ScopedPtrHashMap from device/. (Closed)
Patch Set: one last fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_device_android.cc
diff --git a/device/bluetooth/bluetooth_device_android.cc b/device/bluetooth/bluetooth_device_android.cc
index ce76d20b169b8667980d7833366732b7a95be885..c9cde3fa59880a5a34560fa2f7aa11660767c8fd 100644
--- a/device/bluetooth/bluetooth_device_android.cc
+++ b/device/bluetooth/bluetooth_device_android.cc
@@ -246,17 +246,17 @@ void BluetoothDeviceAndroid::CreateGattRemoteService(
std::string instance_id_string =
base::android::ConvertJavaStringToUTF8(env, instance_id);
- if (gatt_services_.contains(instance_id_string))
+ if (gatt_services_.find(instance_id_string) != gatt_services_.end())
Reilly Grant (use Gerrit) 2016/12/28 22:48:01 if (base::ContainsKey(gatt_services_, instance_id_
Avi (use Gerrit) 2017/01/02 19:42:26 Done.
return;
- BluetoothDevice::GattServiceMap::iterator service_iterator =
- gatt_services_.set(
- instance_id_string,
- BluetoothRemoteGattServiceAndroid::Create(
- GetAndroidAdapter(), this, bluetooth_gatt_service_wrapper,
- instance_id_string, j_device_));
+ std::unique_ptr<BluetoothRemoteGattServiceAndroid> service =
+ BluetoothRemoteGattServiceAndroid::Create(GetAndroidAdapter(), this,
+ bluetooth_gatt_service_wrapper,
+ instance_id_string, j_device_);
+ BluetoothRemoteGattServiceAndroid* service_ptr = service.get();
+ gatt_services_[instance_id_string] = std::move(service);
- adapter_->NotifyGattServiceAdded(service_iterator->second);
+ adapter_->NotifyGattServiceAdded(service_ptr);
}
BluetoothDeviceAndroid::BluetoothDeviceAndroid(BluetoothAdapterAndroid* adapter)

Powered by Google App Engine
This is Rietveld 408576698