chrome/browser/ntp_snippets/ntp_snippets_features.h - Issue 2606753002: Post notification after fetching articles

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ntp_snippets/ntp_snippets_features.h

Issue 2606753002: Post notification after fetching articles (Closed)

Patch Set: Add TODO. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ntp_snippets/content_suggestions_notifier_service_factory.cc ('k') | chrome/browser/ntp_snippets/ntp_snippets_features.cc » ('j') | chrome/browser/ntp_snippets/ntp_snippets_features.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.
	fhorschig 2017/01/05 13:24:35 Do we need that new file because browser features Do we need that new file because browser features don't belong in src/components/ntp_snippets/features.{h,cc}? Couldn't we drop the ntp_snippets_ prefix then for consistency? sfiera 2017/01/05 13:35:01 I don't think that notifications features belong t Show quoted text On 2017/01/05 13:24:35, fhorschig wrote: > Do we need that new file because browser features don't belong in > src/components/ntp_snippets/features.{h,cc}? I don't think that notifications features belong there, since they wouldn't (can't) be used within the component itself. Show quoted text > Couldn't we drop the ntp_snippets_ prefix then for consistency? There's already a features.cc in the //chrome/browser target, and targets can't have multiple files with the same basename.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_NTP_SNIPPETS_NTP_SNIPPETS_FEATURES_H_

	6 #define CHROME_BROWSER_NTP_SNIPPETS_NTP_SNIPPETS_FEATURES_H_

	7

	8 #include "base/feature_list.h"

	9

	10 // Enables and configures notifications for content suggestions.

	11 extern const base::Feature kContentSuggestionsNotificationsFeature;

	12

	13 // "false": use server signals to decide whether to send a notification

	14 // "true": always send a notification when we receive ARTICLES suggestions

	15 extern const char kContentSuggestionsNotificationsAlwaysNotifyParam[];

	16

	17 #endif // CHROME_BROWSER_NTP_SNIPPETS_NTP_SNIPPETS_FEATURES_H_

OLD	NEW