chrome/browser/ntp_snippets/ntp_snippets_features.cc - Issue 2606753002: Post notification after fetching articles

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ntp_snippets/ntp_snippets_features.cc

Issue 2606753002: Post notification after fetching articles (Closed)

Patch Set: Add TODO. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ntp_snippets/ntp_snippets_features.h"

	6

	7 const base::Feature kContentSuggestionsNotificationsFeature = {

	8 "ContentSuggestionsNotifications", base::FEATURE_DISABLED_BY_DEFAULT};
	fhorschig 2017/01/05 13:24:35 Wouldn't it make sense to put that into the ntp_sn Wouldn't it make sense to put that into the ntp_snippets namespace? (Helper functions would then feel home here ... analog to /components/ntp_snippets/features.cc) sfiera 2017/01/05 13:35:01 We don't seem to use that namespace in chrome/brow Show quoted text On 2017/01/05 13:24:35, fhorschig wrote: > Wouldn't it make sense to put that into the ntp_snippets namespace? We don't seem to use that namespace in chrome/browser/ntp_snippets. I would be happy if it was common practice, though. Show quoted text > (Helper functions would then feel home here ... analog to > /components/ntp_snippets/features.cc) Bernhard Bauer 2017/01/05 13:40:58 The rough (i.e. not always followed) rule of thumb Show quoted text On 2017/01/05 13:35:01, sfiera wrote: > On 2017/01/05 13:24:35, fhorschig wrote: > > Wouldn't it make sense to put that into the ntp_snippets namespace? > > We don't seem to use that namespace in chrome/browser/ntp_snippets. I would be > happy if it was common practice, though. The rough (i.e. not always followed) rule of thumb is that things in chrome/ go into the top-level namespace and things in components go into a namespace named after the component.
	9

	10 const char kContentSuggestionsNotificationsAlwaysNotifyParam[] =

	11 "always_notify";

OLD	NEW