Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter.html

Issue 2606733003: DevTools: clean up ObjectPropertiesSection.createValueElement (Closed)
Patch Set: actually fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter.html
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter.html b/third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter.html
index 4bc6d32f2efb3c02b6242f59debb1cc2cb707e6e..aeb26bce411e24a3af79b278f900d2e967c95419 100644
--- a/third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter.html
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter.html
@@ -4,16 +4,27 @@
<script src="../../http/tests/inspector/console-test.js"></script>
<script>
var obj = {}
-Object.defineProperty(obj, 'foo', {enumerable: true, get: function() { return {a:1,b:2}; }});
-Object.defineProperty(obj, 'bar', {enumerable: false, set: function(x) { this.baz = x; }});
+Object.defineProperty(obj, "foo", {enumerable: true, get: function() { return {a:1,b:2}; }});
+Object.defineProperty(obj, "bar", {enumerable: false, set: function(x) { this.baz = x; }});
var arr = [];
Object.defineProperty(arr, 0, {enumerable: true, get: function() { return 1; }});
Object.defineProperty(arr, 1, {enumerable: false, set: function(x) { this.baz = x; }});
+
+var myError = new Error("myError");
+myError.stack = "custom stack";
+var objWithGetterExceptions = {
+ get error() { throw myError },
+ get string() { throw "myString" },
+ get number() { throw 123 },
+ get function() { throw function() {} },
+};
+
function logObject()
{
console.log(obj);
console.log(arr);
+ console.log(objWithGetterExceptions);
}
function test()
@@ -34,7 +45,7 @@ function test()
}
function step5()
{
- InspectorTest.dumpConsoleMessages();
+ InspectorTest.dumpConsoleMessages(false, true);
InspectorTest.completeTest();
}
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698