encrypted-media tests should not count # of SuspendableObjects

third_party/WebKit/Source/core/testing/Internals.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 1463 matching lines @@
 
 // Optimally, the bindings generator would pass a Vector<AtomicString> here but
 // this is not supported yet.
 void Internals::setUserPreferredLanguages(const Vector<String>& languages) {
   Vector<AtomicString> atomicLanguages;
   for (size_t i = 0; i < languages.size(); ++i)
     atomicLanguages.append(AtomicString(languages[i]));
   overrideUserPreferredLanguages(atomicLanguages);
 }
 
+unsigned Internals::mediaKeysCount() {
+  return InstanceCounters::counterValue(InstanceCounters::MediaKeysCounter);

[sof, 2016/12/26 08:00:47]

I'm unsure if it is acceptable for these to use global per-renderer process
counts, rather than per-document. (Delayed GCing of documents might lead to
flakiness for some test orderings..? )

[haraken, 2016/12/26 08:17:18]

That's why I inserted gc() in the beginning of these tests. Does it look okay?

[sof, 2016/12/26 09:23:06]

i think so, it's reasonable to require the caller to have called gc() first.

(I suspect the same change is possible for suspendableObjectCount(), and have it
be in terms of InstanceCounters instead.)

+}
+
+unsigned Internals::mediaKeySessionCount() {
+  return InstanceCounters::counterValue(
+      InstanceCounters::MediaKeySessionCounter);
+}
+
 unsigned Internals::suspendableObjectCount(Document* document) {
   DCHECK(document);
   return document->suspendableObjectCount();
 }
 
 static unsigned eventHandlerCount(
     Document& document,
     EventHandlerRegistry::EventHandlerClass handlerClass) {
   if (!document.frameHost())
     return 0;
@@ skipping 1586 matching lines @@
 
 void Internals::crash() {
   CHECK(false) << "Intentional crash";
 }
 
 void Internals::setIsLowEndDevice(bool isLowEndDevice) {
   MemoryCoordinator::setIsLowEndDeviceForTesting(isLowEndDevice);
 }
 
 }  // namespace blink