AppListController now responsible for ensuring app list stays centered.

ash/wm/app_list_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/app_list_controller.h"
 
 #include "ash/ash_switches.h"
 #include "ash/root_window_controller.h"
 #include "ash/screen_util.h"
 #include "ash/shelf/shelf.h"
@@ skipping 95 matching lines @@
           0, std::max(kMinimalAnchorPositionOffset - anchor.y(), 0));
     case SHELF_ALIGNMENT_RIGHT:
       return gfx::Vector2d(
           0, std::max(kMinimalAnchorPositionOffset - anchor.y(), 0));
     default:
       NOTREACHED();
       return gfx::Vector2d();
   }
 }
 
+// Gets the point at the center of the screen.
+gfx::Point GetScreenCenter() {
+  return Shell::GetScreen()->GetPrimaryDisplay().bounds().CenterPoint();
+}
+
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // AppListController, public:
 
 AppListController::AppListController()
     : pagination_model_(new app_list::PaginationModel),
       is_visible_(false),
+      is_centered_(false),
       view_(NULL),
       should_snap_back_(false) {
   Shell::GetInstance()->AddShellObserver(this);
   pagination_model_->AddObserver(this);
 }
 
 AppListController::~AppListController() {
   // Ensures app list view goes before the controller since pagination model
   // lives in the controller and app list view would access it on destruction.
   if (view_ && view_->GetWidget())
@@ skipping 24 matching lines @@
       view_->GetWidget()->Deactivate();
     ScheduleAnimation();
   } else if (is_visible_) {
     // AppListModel and AppListViewDelegate are owned by AppListView. They
     // will be released with AppListView on close.
     app_list::AppListView* view = new app_list::AppListView(
         Shell::GetInstance()->delegate()->CreateAppListViewDelegate());
     aura::Window* root_window = window->GetRootWindow();
     aura::Window* container = GetRootWindowController(root_window)->
         GetContainer(kShellWindowId_AppListContainer);
     if (app_list::switches::IsExperimentalAppListPositionEnabled()) {

[varkha, 2014/04/30 16:37:38]

nit: maybe:
is_centered_ = app_list::switches::IsExperimentalAppListPositionEnabled();
if (is_centered_) {

[Matt Giuca, 2014/05/01 03:54:32]

Done. (Nice)

       // The experimental app list is centered over the primary display.
-      view->InitAsBubbleCenteredOnPrimaryDisplay(
+      is_centered_ = true;
+      view->InitAsBubbleAtFixedLocation(
           NULL,
           pagination_model_.get(),
-          Shell::GetScreen(),
+          Shell::GetScreen()->GetPrimaryDisplay().bounds().CenterPoint(),

[varkha, 2014/04/30 16:37:38]

Could use GetScreenCenter().

[Matt Giuca, 2014/05/01 03:54:32]

I can't find anything called GetScreenCenter or ScreenCenter in the Chrome
codebase...

[varkha, 2014/05/01 03:57:21]

It's a new method in this file's anonymous namespace that you added - line 116
(?)

[Matt Giuca, 2014/05/01 04:02:43]

/me hits self over head with hammer.

Sorry, I must have been searching in the wrong branch. I completely forgot about
this, but in fact the entire *point* of abstracting out that method was to use
it here (and in the other place). Thanks for pointing this out.

[varkha, 2014/05/01 04:04:50]

Great, you got it in time.

           views::BubbleBorder::FLOAT,
           true /* border_accepts_events */);
     } else {
+      is_centered_ = false;
       gfx::Rect applist_button_bounds = Shelf::ForWindow(container)->
           GetAppListButtonView()->GetBoundsInScreen();
       // We need the location of the button within the local screen.
       applist_button_bounds = ScreenUtil::ConvertRectFromScreen(
           root_window,
           applist_button_bounds);
       view->InitAsBubbleAttachedToAnchor(
           container,
           pagination_model_.get(),
           Shelf::ForWindow(container)->GetAppListButtonView(),
@@ skipping 108 matching lines @@
         return;
     }
   }
 
   aura::Window* window = view_->GetWidget()->GetNativeView()->parent();
   if (!window->Contains(target))
     SetVisible(false, window);
 }
 
 void AppListController::UpdateBounds() {
-  if (view_ && is_visible_)
-    view_->UpdateBounds();
+  if (!view_ || !is_visible_)
+    return;
+
+  view_->UpdateBounds();
+
+  if (is_centered_)
+    view_->SetAnchorPoint(GetScreenCenter());
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AppListController, aura::EventFilter implementation:
 
 void AppListController::OnMouseEvent(ui::MouseEvent* event) {
   if (event->type() == ui::ET_MOUSE_PRESSED)
     ProcessLocatedEvent(event);
 }
 
@@ skipping 104 matching lines @@
   } else if (should_snap_back_) {
     should_snap_back_ = false;
     ui::ScopedLayerAnimationSettings animation(widget_animator);
     animation.SetTransitionDuration(base::TimeDelta::FromMilliseconds(
         app_list::kOverscrollPageTransitionDurationMs));
     widget->SetBounds(view_bounds_);
   }
 }
 
 }  // namespace ash