Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2606593002: [ServiceWorker] Associate interfaces.

Created:
3 years, 12 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 12 months ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Associate interfaces. BUG=

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -103 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 12 chunks +63 lines, -42 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 1 5 chunks +4 lines, -10 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 6 chunks +24 lines, -29 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
A content/public/test/fake_associated_interface_provider_impl.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A content/public/test/fake_associated_interface_provider_impl.cc View 1 1 chunk +38 lines, -0 lines 0 comments Download
A content/public/test/foo_interface.mojom View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_instance_client_impl.h View 4 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_instance_client_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/associated_interface_ptr.h View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (8 generated)
leonhsl(Using Gerrit)
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
3 years, 12 months ago (2016-12-25 01:55:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606593002/1
3 years, 12 months ago (2016-12-25 01:56:07 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 12 months ago (2016-12-25 02:30:01 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/283305)
3 years, 12 months ago (2016-12-25 02:30:01 UTC) #4
leonhsl(Using Gerrit)
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
3 years, 12 months ago (2016-12-27 13:49:30 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606593002/20001
3 years, 12 months ago (2016-12-27 13:49:37 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 12 months ago (2016-12-27 15:45:13 UTC) #7
commit-bot: I haz the power
3 years, 12 months ago (2016-12-27 15:45:14 UTC) #8 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698