Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: components/autofill/content/browser/content_autofill_driver_unittest.cc

Issue 2606473003: Use AutofillDriver* in ContentAutofillDriverFactory when possible (Closed)
Patch Set: Fix Android compilation Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/content_autofill_driver_unittest.cc
diff --git a/components/autofill/content/browser/content_autofill_driver_unittest.cc b/components/autofill/content/browser/content_autofill_driver_unittest.cc
index 3dbbd572f3c684364d9d1b4862b645c751bd3109..1dda7b2dd7409ea1af1c17a9e0e9540adebff3a9 100644
--- a/components/autofill/content/browser/content_autofill_driver_unittest.cc
+++ b/components/autofill/content/browser/content_autofill_driver_unittest.cc
@@ -21,12 +21,10 @@
#include "components/autofill/core/common/autofill_switches.h"
#include "components/autofill/core/common/form_data_predictions.h"
#include "content/public/browser/browser_context.h"
-#include "content/public/browser/navigation_details.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/ssl_status.h"
#include "content/public/browser/storage_partition.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/common/frame_navigate_params.h"
#include "content/public/test/test_renderer_host.h"
#include "mojo/public/cpp/bindings/binding_set.h"
#include "services/service_manager/public/cpp/interface_provider.h"
@@ -256,8 +254,6 @@ class TestContentAutofillDriver : public ContentAutofillDriver {
virtual MockAutofillManager* mock_autofill_manager() {
return static_cast<MockAutofillManager*>(autofill_manager());
}
-
- using ContentAutofillDriver::DidNavigateFrame;
};
class ContentAutofillDriverTest : public content::RenderViewHostTestHarness {
@@ -302,21 +298,7 @@ TEST_F(ContentAutofillDriverTest, GetURLRequestContext) {
TEST_F(ContentAutofillDriverTest, NavigatedToDifferentPage) {
EXPECT_CALL(*driver_->mock_autofill_manager(), Reset());
- content::LoadCommittedDetails details = content::LoadCommittedDetails();
- details.is_main_frame = true;
- details.is_in_page = false;
- ASSERT_TRUE(details.is_navigation_to_different_page());
- content::FrameNavigateParams params = content::FrameNavigateParams();
- driver_->DidNavigateFrame(details, params);
-}
-
-TEST_F(ContentAutofillDriverTest, NavigatedWithinSamePage) {
- EXPECT_CALL(*driver_->mock_autofill_manager(), Reset()).Times(0);
- content::LoadCommittedDetails details = content::LoadCommittedDetails();
- details.is_main_frame = false;
- ASSERT_TRUE(!details.is_navigation_to_different_page());
- content::FrameNavigateParams params = content::FrameNavigateParams();
- driver_->DidNavigateFrame(details, params);
+ driver_->NavigatedToDifferentPage();
}
TEST_F(ContentAutofillDriverTest, FormDataSentToRenderer_FillForm) {

Powered by Google App Engine
This is Rietveld 408576698