Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2606313002: Fix the patched_sdk GN build. (Closed)

Created:
3 years, 11 months ago by Kevin Millikin (Google)
Modified:
3 years, 11 months ago
Reviewers:
erikcorry, kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the patched_sdk GN build. The typed_data patch needs to be listed explicitly. BUG= R=erikcorry@google.com, kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/ee587598e4b0cddebba892e4d0b2b3ea95936789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M runtime/vm/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kevin Millikin (Google)
3 years, 11 months ago (2017-01-03 09:29:38 UTC) #2
erikcorry
lgtm
3 years, 11 months ago (2017-01-03 09:34:21 UTC) #3
kustermann
LGTM
3 years, 11 months ago (2017-01-03 09:34:58 UTC) #4
Kevin Millikin (Google)
3 years, 11 months ago (2017-01-03 09:39:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee587598e4b0cddebba892e4d0b2b3ea95936789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698