Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2757)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc

Issue 2606293002: Remove ScopedVector from chrome/browser/ui. (Closed)
Patch Set: one last fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc
diff --git a/chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc b/chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc
index bfc40de79986c6e1dd65d1162853f6df89d7a591..de85749104cc4b7e262d3b91c4a446880f56d159 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc
+++ b/chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/website_settings/permission_bubble_browser_test_util.h"
#include "base/command_line.h"
+#include "base/memory/ptr_util.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/permissions/mock_permission_request.h"
#include "chrome/browser/ui/browser.h"
@@ -31,10 +32,9 @@ void PermissionBubbleBrowserTest::SetUpOnMainThread() {
ExtensionBrowserTest::SetUpOnMainThread();
// Add a single permission request.
- MockPermissionRequest* request = new MockPermissionRequest(
+ requests_.push_back(base::MakeUnique<MockPermissionRequest>(
"Request 1", l10n_util::GetStringUTF8(IDS_PERMISSION_ALLOW),
- l10n_util::GetStringUTF8(IDS_PERMISSION_DENY));
- requests_.push_back(request);
+ l10n_util::GetStringUTF8(IDS_PERMISSION_DENY)));
}
Browser* PermissionBubbleBrowserTest::OpenExtensionAppWindow() {
@@ -56,6 +56,13 @@ Browser* PermissionBubbleBrowserTest::OpenExtensionAppWindow() {
return app_browser;
}
+std::vector<PermissionRequest*> PermissionBubbleBrowserTest::requests() {
+ std::vector<PermissionRequest*> result;
+ for (const auto& request : requests_)
+ result.push_back(request.get());
+ return result;
+}
+
PermissionBubbleKioskBrowserTest::PermissionBubbleKioskBrowserTest() {
}

Powered by Google App Engine
This is Rietveld 408576698