Remove ScopedVector from chrome/browser/ui.

chrome/browser/ui/views/hung_renderer_view.cc

Index: chrome/browser/ui/views/hung_renderer_view.cc
diff --git a/chrome/browser/ui/views/hung_renderer_view.cc b/chrome/browser/ui/views/hung_renderer_view.cc
index 83ef593c26043be5b21da289a948062175b21908..9d615737e6f1968a0c868bd9be1599bb534396de 100644
--- a/chrome/browser/ui/views/hung_renderer_view.cc
+++ b/chrome/browser/ui/views/hung_renderer_view.cc
@@ -5,6 +5,7 @@
 #include "chrome/browser/ui/views/hung_renderer_view.h"
 
 #include "base/i18n/rtl.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
@@ -80,13 +81,14 @@ void HungPagesTableModel::InitForWebContents(WebContents* hung_contents) {
   if (hung_contents) {
     // Force hung_contents to be first.
     if (hung_contents) {
-      tab_observers_.push_back(new WebContentsObserverImpl(this,
-                                                           hung_contents));
+      tab_observers_.push_back(
+          base::MakeUnique<WebContentsObserverImpl>(this, hung_contents));
     }
     for (TabContentsIterator it; !it.done(); it.Next()) {
       if (*it != hung_contents &&
           it->GetRenderProcessHost() == hung_contents->GetRenderProcessHost())
-        tab_observers_.push_back(new WebContentsObserverImpl(this, *it));
+        tab_observers_.push_back(
+            base::MakeUnique<WebContentsObserverImpl>(this, *it));
     }
   }
   // The world is different.
@@ -134,8 +136,11 @@ void HungPagesTableModel::GetGroupRange(int model_index,
 
 void HungPagesTableModel::TabDestroyed(WebContentsObserverImpl* tab) {
   // Clean up tab_observers_ and notify our observer.
-  TabObservers::iterator i = std::find(
-      tab_observers_.begin(), tab_observers_.end(), tab);
+  auto i = tab_observers_.begin();
+  for (; i != tab_observers_.end(); ++i) {
+    if (i->get() == tab)
+      break;
+  }
   DCHECK(i != tab_observers_.end());
   int index = static_cast<int>(i - tab_observers_.begin());

[Nico, 2017/01/03 23:15:44]

i meant this subtraction is kind of silly; if you looped over an int instead of
an iterator you wouldn't need this. (this is a vector after all)

size_t index = 0;
for (; index < tab_observers.size(); ++index)
  if tab_observers[index].get() == tab
    break
DCHECK(i < tab_observers.size());

[Avi (use Gerrit), 2017/01/04 00:04:50]

Done.

   tab_observers_.erase(i);