Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1644)

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc

Issue 2606293002: Remove ScopedVector from chrome/browser/ui. (Closed)
Patch Set: view Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
diff --git a/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc b/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
index 1db67ced381730ba488a9a026350d24d12c5dd6c..95b1a5654a395f36505318caf177236b63c87f30 100644
--- a/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
+++ b/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
@@ -38,8 +38,7 @@ std::string VerifyToolbarOrderForBar(
const char* expected_names[],
size_t total_size,
size_t visible_count) {
- const std::vector<ToolbarActionViewController*>& toolbar_actions =
- actions_bar->toolbar_actions_unordered();
+ const auto& toolbar_actions = actions_bar->toolbar_actions_unordered();
Nico 2017/01/03 18:12:35 i think style guide says that this should have an
Avi (use Gerrit) 2017/01/03 22:54:53 Done.
// If the total size is wrong, we risk segfaulting by continuing. Abort now.
if (total_size != toolbar_actions.size()) {
return base::StringPrintf("Incorrect action count: expected %d, found %d",

Powered by Google App Engine
This is Rietveld 408576698