Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2606253002: Move dart_types to elements/resolution_types (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move dart_types to elements/resolution_types - to prepare for a new dart_types super-hierarchy based on entities. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/56cdde298db176ab83c0738e928b0e0db1383321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -2120 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/constant_system_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/constant_constructors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/constant_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/constructors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/core_types.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/compiler/lib/src/dart_types.dart View 1 chunk +0 lines, -1995 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +1 line, -1 line 0 comments Download
A + pkg/compiler/lib/src/elements/resolution_types.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/constant_ordering.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/error.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/unresolved.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_result.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/scope.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/constant_serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/impact_serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/serialization_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/type_serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/values.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/abstract_value_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/feature.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_dart2js_helpers_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/flatten_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/least_upper_bound_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/lookup_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/members_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mixin_typevariable_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/subtype_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_equals_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_order_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_variable_occurrence_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
I prefer `resolution` over `resolved` since they might not have been resolved (yet) when used ...
3 years, 11 months ago (2017-01-02 14:21:21 UTC) #2
Johnni Winther
ping
3 years, 11 months ago (2017-01-03 10:03:11 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 11 months ago (2017-01-03 16:52:06 UTC) #4
Johnni Winther
3 years, 11 months ago (2017-01-04 09:07:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
56cdde298db176ab83c0738e928b0e0db1383321 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698