Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: content/common/view_messages.h

Issue 260623004: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index 3a27d79b58fed554f96998cd63a83da3d1b8fa49..0256cad5677c20b739dedca6efc8828f4e8ff87e 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -366,6 +366,14 @@ IPC_STRUCT_BEGIN(ViewHostMsg_ShowPopup_Params)
IPC_STRUCT_MEMBER(bool, allow_multiple_selection)
IPC_STRUCT_END()
+IPC_STRUCT_BEGIN(ViewHostMsg_SmartClip_Params)
+// Clip rect bounds on the screen
+IPC_STRUCT_MEMBER(gfx::Rect, clip_rect)
+
+// The data in the clip_rect from the webpage
+IPC_STRUCT_MEMBER(base::string16, clip_data)
+IPC_STRUCT_END()
+
IPC_STRUCT_BEGIN(ViewHostMsg_TextInputState_Params)
// The type of input field
IPC_STRUCT_MEMBER(ui::TextInputType, type)
@@ -1743,11 +1751,8 @@ IPC_MESSAGE_ROUTED1(ViewHostMsg_SetNeedsBeginFrame,
bool /* enabled */)
// Reply to the ViewMsg_ExtractSmartClipData message.
-// TODO(juhui24.lee@samsung.com): this should be changed to a vector of structs
-// instead of encoding the data as a string which is not allowed normally. Since
-// ths is only used in Android WebView, it's allowed temporarily.
-// http://crbug.com/330872
-IPC_MESSAGE_ROUTED1(ViewHostMsg_SmartClipDataExtracted, base::string16)
+IPC_MESSAGE_ROUTED1(ViewHostMsg_SmartClipDataExtracted,
+ ViewHostMsg_SmartClip_Params)
#elif defined(OS_MACOSX)
// Request that the browser load a font into shared memory for us.

Powered by Google App Engine
This is Rietveld 408576698