Chromium Code Reviews| Index: base/test/launcher/test_result.cc |
| diff --git a/base/test/launcher/test_result.cc b/base/test/launcher/test_result.cc |
| index 39e20e7f01fca47687b3cd10b3c5abf82afa11b0..761b273b8c9c52ba9d32f41876f825dd3bd81530 100644 |
| --- a/base/test/launcher/test_result.cc |
| +++ b/base/test/launcher/test_result.cc |
| @@ -10,12 +10,53 @@ |
| namespace base { |
| +TestResultPart::TestResultPart() = default; |
| +TestResultPart::~TestResultPart() = default; |
| + |
| +TestResultPart::TestResultPart(const TestResultPart& other) = default; |
| +TestResultPart::TestResultPart(TestResultPart&& other) = default; |
| +TestResultPart& TestResultPart::operator=(const TestResultPart& other) = |
| + default; |
| +TestResultPart& TestResultPart::operator=(TestResultPart&& other) = default; |
| + |
| +// static |
| +bool TestResultPart::TypeFromString(const std::string& str, Type* type) { |
| + if (str == "success") |
| + *type = kSuccess; |
| + else if (str == "failure") |
| + *type = kNonFatalFailure; |
| + else if (str == "fatal_failure") |
| + *type = kFatalFailure; |
| + else |
| + return false; |
| + return true; |
| +} |
| + |
| +std::string TestResultPart::TypeAsString() const { |
| + switch (type) { |
| + case kSuccess: |
| + return "success"; |
| + case kNonFatalFailure: |
| + return "failure"; |
| + case kFatalFailure: |
| + return "fatal_failure"; |
| + default: |
| + NOTREACHED(); |
| + } |
| + return ""; |
|
Paweł Hajdan Jr.
2016/12/30 19:02:39
Should this return "unknown"?
alex-ac
2016/12/30 22:10:20
This is NOTREACHED() case, and i assume will alway
|
| +} |
| + |
| TestResult::TestResult() : status(TEST_UNKNOWN) { |
| } |
| TestResult::~TestResult() { |
| } |
| +TestResult::TestResult(const TestResult& other) = default; |
| +TestResult::TestResult(TestResult&& other) = default; |
| +TestResult& TestResult::operator=(const TestResult& other) = default; |
| +TestResult& TestResult::operator=(TestResult&& other) = default; |
| + |
| std::string TestResult::StatusAsString() const { |
| switch (status) { |
| case TEST_UNKNOWN: |