Report failed expect/assert to test launcher summary output.

base/test/launcher/test_results_tracker.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/launcher/test_results_tracker.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 354 matching lines @@
         test_result_value->SetBoolean("losless_snippet", lossless_snippet);
 
         // Also include the raw version (base64-encoded so that it can be safely
         // JSON-serialized - there are no guarantees about character encoding
         // of the snippet). This can be very useful piece of information when
         // debugging a test failure related to character encoding.
         std::string base64_output_snippet;
         Base64Encode(test_result.output_snippet, &base64_output_snippet);
         test_result_value->SetString("output_snippet_base64",
                                      base64_output_snippet);
+
+        std::unique_ptr<ListValue> test_result_parts(new ListValue);
+        for (const TestResultPart& result_part :
+             test_result.test_result_parts) {
+          std::unique_ptr<DictionaryValue> result_part_value(
+              new DictionaryValue);
+          result_part_value->SetString("type", result_part.TypeAsString());
+          result_part_value->SetString("file", result_part.file_name);
+          result_part_value->SetInteger("line", result_part.line_number);
+          if (IsStringUTF8(result_part.summary)) {
+            result_part_value->SetString("summary", result_part.summary);
+          } else {
+            std::string encoded_summary;
+            Base64Encode(result_part.summary, &encoded_summary);
+            result_part_value->SetString("summary_base64", encoded_summary);

[Paweł Hajdan Jr., 2016/12/30 19:02:39]

Could you follow pattern for "output_snippet"? Make the non-encoded key always
set, and make it point to encoded one when needed. Same below for message.

[alex-ac, 2016/12/30 22:10:20]

Done.

[Paweł Hajdan Jr., 2017/01/02 09:21:37]

Please address  the "make the non-encoded key always set" part of my comment. It
seems better for "summary" to always be present, similar to code above which I
pointed to:

<non-UTF-8 snippet, see output_snippet_base64> (change text accordingly)

[alex-ac, 2017/01/03 08:28:59]

Done.

+          }
+          if (IsStringUTF8(result_part.message)) {
+            result_part_value->SetString("message", result_part.message);
+          } else {
+            std::string encoded_message;
+            Base64Encode(result_part.message, &encoded_message);
+            result_part_value->SetString("message_base64", encoded_message);
+          }
+          test_result_parts->Append(std::move(result_part_value));
+        }
+        test_result_value->Set("result_parts", std::move(test_result_parts));
+
         test_results->Append(std::move(test_result_value));
       }
 
       current_iteration_data->SetWithoutPathExpansion(j->first,
                                                       std::move(test_results));
     }
     per_iteration_data->Append(std::move(current_iteration_data));
   }
   summary_root->Set("per_iteration_data", std::move(per_iteration_data));
 
@@ skipping 78 matching lines @@
 TestResultsTracker::PerIterationData::PerIterationData() {
 }
 
 TestResultsTracker::PerIterationData::PerIterationData(
     const PerIterationData& other) = default;
 
 TestResultsTracker::PerIterationData::~PerIterationData() {
 }
 
 }  // namespace base