sync/engine/directory_commit_contribution_unittest.cc - Issue 260613002: sync: Expose DirectoryDebugInfoEmitters in engine

Unified Diff: sync/engine/directory_commit_contribution_unittest.cc

Issue 260613002: sync: Expose DirectoryDebugInfoEmitters in engine (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/engine/directory_commit_contribution_unittest.cc

diff --git a/sync/engine/directory_commit_contribution_unittest.cc b/sync/engine/directory_commit_contribution_unittest.cc

index e17817c3f8aa58b382c40cfd88009b82318dfde6..867fcdeb6ac327ea1ac1783f8da13c996fe20b90 100644

--- a/sync/engine/directory_commit_contribution_unittest.cc

+++ b/sync/engine/directory_commit_contribution_unittest.cc

@@ -85,8 +85,9 @@ TEST_F(DirectoryCommitContributionTest, GatherByTypes) {

CreateUnsyncedItem(&trans, EXTENSIONS, "extension1");

}

+ DirectoryTypeDebugInfoEmitter emitter;

scoped_ptr<DirectoryCommitContribution> cc(

- DirectoryCommitContribution::Build(dir(), PREFERENCES, 5));

+ DirectoryCommitContribution::Build(dir(), PREFERENCES, 5, &emitter));

ASSERT_EQ(2U, cc->GetNumEntries());

const std::vector<int64>& metahandles = cc->metahandles_;

@@ -110,8 +111,9 @@ TEST_F(DirectoryCommitContributionTest, GatherAndTruncate) {

CreateUnsyncedItem(&trans, EXTENSIONS, "extension1");

}

+ DirectoryTypeDebugInfoEmitter emitter;

scoped_ptr<DirectoryCommitContribution> cc(

- DirectoryCommitContribution::Build(dir(), PREFERENCES, 1));

+ DirectoryCommitContribution::Build(dir(), PREFERENCES, 1, &emitter));

ASSERT_EQ(1U, cc->GetNumEntries());

int64 only_metahandle = cc->metahandles_[0];

@@ -132,10 +134,12 @@ TEST_F(DirectoryCommitContributionTest, PrepareCommit) {

CreateUnsyncedItem(&trans, EXTENSIONS, "extension1");

}

+ DirectoryTypeDebugInfoEmitter emitter1;

+ DirectoryTypeDebugInfoEmitter emitter2;

scoped_ptr<DirectoryCommitContribution> pref_cc(

- DirectoryCommitContribution::Build(dir(), PREFERENCES, 25));

+ DirectoryCommitContribution::Build(dir(), PREFERENCES, 25, &emitter1));

scoped_ptr<DirectoryCommitContribution> ext_cc(

- DirectoryCommitContribution::Build(dir(), EXTENSIONS, 25));

+ DirectoryCommitContribution::Build(dir(), EXTENSIONS, 25, &emitter2));

sync_pb::ClientToServerMessage message;

pref_cc->AddToCommitMessage(&message);

@@ -184,10 +188,12 @@ TEST_F(DirectoryCommitContributionTest, ProcessCommitResponse) {

ext1_handle = CreateUnsyncedItem(&trans, EXTENSIONS, "extension1");

}

+ DirectoryTypeDebugInfoEmitter emitter1;

+ DirectoryTypeDebugInfoEmitter emitter2;

scoped_ptr<DirectoryCommitContribution> pref_cc(

- DirectoryCommitContribution::Build(dir(), PREFERENCES, 25));

+ DirectoryCommitContribution::Build(dir(), PREFERENCES, 25, &emitter1));

scoped_ptr<DirectoryCommitContribution> ext_cc(

- DirectoryCommitContribution::Build(dir(), EXTENSIONS, 25));

+ DirectoryCommitContribution::Build(dir(), EXTENSIONS, 25, &emitter2));

sync_pb::ClientToServerMessage message;

pref_cc->AddToCommitMessage(&message);

« no previous file with comments | « sync/engine/directory_commit_contribution.cc ('k') | sync/engine/directory_commit_contributor.h » ('j') | no next file with comments »