Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: src/objects-debug.cc

Issue 2606093002: [promises] Refactor debug code (Closed)
Patch Set: fmt Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/debug/debug.h ('K') | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index 67d2ac7a362c0b0aabe635e320a5871b79305cb8..98b1df2f8a4b109447c734e2fbcd9b0cf9641883 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -1021,8 +1021,8 @@ void PromiseResolveThenableJobInfo::PromiseResolveThenableJobInfoVerify() {
CHECK(then()->IsJSReceiver());
CHECK(resolve()->IsJSFunction());
CHECK(reject()->IsJSFunction());
- CHECK(debug_id()->IsNumber() || debug_id()->IsUndefined(isolate));
- CHECK(debug_name()->IsString() || debug_name()->IsUndefined(isolate));
+ VerifySmiField(kDebugIdOffset);
+ VerifySmiField(kDebugNameOffset);
CHECK(context()->IsContext());
}
@@ -1041,8 +1041,8 @@ void PromiseReactionJobInfo::PromiseReactionJobInfoVerify() {
CHECK(deferred_on_reject()->IsUndefined(isolate) ||
deferred_on_reject()->IsCallable() ||
deferred_on_reject()->IsFixedArray());
- CHECK(debug_id()->IsNumber() || debug_id()->IsUndefined(isolate));
- CHECK(debug_name()->IsString() || debug_name()->IsUndefined(isolate));
+ VerifySmiField(kDebugIdOffset);
+ VerifySmiField(kDebugNameOffset);
CHECK(context()->IsContext());
}
« src/debug/debug.h ('K') | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698