[promises] Refactor debug code

src/debug/debug.h

Index: src/debug/debug.h
diff --git a/src/debug/debug.h b/src/debug/debug.h
index 90d1791f6a73b60577f012390cf7459a3bd33808..893a60326e01cbef778992381dafeed86442e981 100644
--- a/src/debug/debug.h
+++ b/src/debug/debug.h
@@ -71,6 +71,24 @@ enum DebugBreakType {
   DEBUG_BREAK_SLOT_AT_TAIL_CALL,
 };
 
+const int DEBUG_PROMISE_DEFAULT_ID = 0;

[adamk, 2017/01/03 18:18:17]

kDebugPromiseDefaultId please. SHOUTING_CASE is only for macros and "legacy"
enums.

Also, is this the "default" id or does this represent something like "no debug
id?" Maybe kDebugPromiseNoId?

+
+enum PromiseDebugActionName {
+  DEBUG_NOT_ACTIVE,
+  DEBUG_ASYNC_FUNCTION,
+  DEBUG_PROMISE_RESOLVE,
+  DEBUG_PROMISE_REJECT,
+  DEBUG_PROMISE_RESOLVE_THENABLE_JOB,
+};
+
+enum PromiseDebugActionType {
+  DEBUG_ENQUEUE,
+  DEBUG_ENQUEUE_RECURRING,
+  DEBUG_CANCEL,
+  DEBUG_WILL_HANDLE,
+  DEBUG_DID_HANDLE,
+};
+
 class BreakLocation {
  public:
   static BreakLocation FromFrame(Handle<DebugInfo> debug_info,
@@ -407,8 +425,8 @@ class Debug {
   void OnPromiseReject(Handle<Object> promise, Handle<Object> value);
   void OnCompileError(Handle<Script> script);
   void OnAfterCompile(Handle<Script> script);
-  void OnAsyncTaskEvent(Handle<String> type, Handle<Object> id,
-                        Handle<String> name);
+  void OnAsyncTaskEvent(PromiseDebugActionType type, int id,
+                        PromiseDebugActionName name);
 
   // API facing.
   void SetEventListener(Handle<Object> callback, Handle<Object> data);
@@ -584,9 +602,9 @@ class Debug {
       Handle<Object> promise);
   MUST_USE_RESULT MaybeHandle<Object> MakeCompileEvent(
       Handle<Script> script, v8::DebugEvent type);
-  MUST_USE_RESULT MaybeHandle<Object> MakeAsyncTaskEvent(Handle<String> type,
-                                                         Handle<Object> id,
-                                                         Handle<String> name);
+  MUST_USE_RESULT MaybeHandle<Object> MakeAsyncTaskEvent(Handle<Smi> type,
+                                                         Handle<Smi> id,
+                                                         Handle<Smi> name);
 
   // Mirror cache handling.
   void ClearMirrorCache();