[promises] Refactor debug code

src/objects-debug.cc

Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index 67d2ac7a362c0b0aabe635e320a5871b79305cb8..3eab9134585b7fb055d02e5d8c2ec732cbb7e6ae 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -1021,8 +1021,6 @@ void PromiseResolveThenableJobInfo::PromiseResolveThenableJobInfoVerify() {
   CHECK(then()->IsJSReceiver());
   CHECK(resolve()->IsJSFunction());
   CHECK(reject()->IsJSFunction());
-  CHECK(debug_id()->IsNumber() || debug_id()->IsUndefined(isolate));
-  CHECK(debug_name()->IsString() || debug_name()->IsUndefined(isolate));

[adamk, 2016/12/30 00:10:04]

I think these should be replaced with VerifySmiField() calls

[gsathya, 2016/12/30 01:48:51]

Done.

   CHECK(context()->IsContext());
 }
 
@@ -1041,8 +1039,6 @@ void PromiseReactionJobInfo::PromiseReactionJobInfoVerify() {
   CHECK(deferred_on_reject()->IsUndefined(isolate) ||
         deferred_on_reject()->IsCallable() ||
         deferred_on_reject()->IsFixedArray());
-  CHECK(debug_id()->IsNumber() || debug_id()->IsUndefined(isolate));
-  CHECK(debug_name()->IsString() || debug_name()->IsUndefined(isolate));

[adamk, 2016/12/30 00:10:04]

Same here

[gsathya, 2016/12/30 01:48:51]

Done.

   CHECK(context()->IsContext());
 }