Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(61)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/browser/resources/print_preview/search/cros_destination_resolver.html
Issue
2606043004
:
Perform printer setup on Chrome OS before selecting printer. (Closed)
Patch Set: fix nit
Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/app/generated_resources.grd
chrome/browser/resources/print_preview/data/destination.js
chrome/browser/resources/print_preview/data/destination_store.js
chrome/browser/resources/print_preview/data/local_parsers.js
chrome/browser/resources/print_preview/native_layer.js
chrome/browser/resources/print_preview/print_preview.html
chrome/browser/resources/print_preview/print_preview.js
chrome/browser/resources/print_preview/search/cros_destination_resolver.html
chrome/browser/resources/print_preview/search/cros_destination_resolver.js
chrome/browser/resources/print_preview/search/destination_search.js
chrome/browser/ui/webui/print_preview/print_preview_handler.h
chrome/browser/ui/webui/print_preview/print_preview_handler.cc
chrome/browser/ui/webui/print_preview/print_preview_ui.cc
chrome/test/BUILD.gn
chrome/test/data/webui/print_preview.js
chrome/test/data/webui/print_preview_destination_search_test.js
View unified diff
|
Download patch
« chrome/browser/resources/print_preview/native_layer.js
('K') |
« chrome/browser/resources/print_preview/print_preview.js
('k') |
chrome/browser/resources/print_preview/search/cros_destination_resolver.js »
('j') |
chrome/browser/resources/print_preview/search/cros_destination_resolver.js »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<div id="cros-printer-resolver" class="overlay transparent" hidden>
2
<div class="page">
3
<div class="close-button"></div>
4
<div class="action-area">
5
<div class="resolving-message" i18n-content="resolveCrosPrinterMessage">
dpapad
2017/01/11 20:36:30
Use i18n{} instead of i18n-content, see other exam
Use i18n{} instead of i18n-content, see other examples in print_preview,
https://cs.chromium.org/search/?q=%22i18n%7B%22+file:%5Esrc/chrome/browser/re...
skau
2017/01/12 00:36:16
Thanks. That's nicer.
Show quoted text
On 2017/01/11 20:36:30, dpapad wrote: > Use i18n{} instead of i18n-content, see other examples in print_preview, >
https://cs.chromium.org/search/?q=%22i18n%7B%22+file:%5Esrc/chrome/browser/re...
Thanks. That's nicer.
6
</div>
7
</div>
8
</div>
9
</div>
OLD
NEW
« chrome/browser/resources/print_preview/native_layer.js
('K') |
« chrome/browser/resources/print_preview/print_preview.js
('k') |
chrome/browser/resources/print_preview/search/cros_destination_resolver.js »
('j') |
chrome/browser/resources/print_preview/search/cros_destination_resolver.js »
('J')
Issue 2606043004: Perform printer setup on Chrome OS before selecting printer. (Closed)
Created 3 years, 11 months ago by skau
Modified 3 years, 11 months ago
Reviewers: dpapad, Vitaly Buka (NO REVIEWS), xdai1
Base URL:
Comments: 54
This is Rietveld
408576698