DevTools: Preserve the selection in StylesSideBar more often

third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Index: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
index 30e0ebbe8a7e4f4206ab7bfea3a42da9ad81dd2d..45904a62414fba7e6006c960ccabcf7111770d56 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
@@ -1240,6 +1240,9 @@ Elements.StylePropertiesSection = class {
     if (!event.target.isComponentSelectionCollapsed())
       return;
 
+    if (!this.propertiesTreeOutline.element.shadowRoot.firstChild.isComponentSelectionCollapsed())

[einbinder, 2016/12/29 08:58:45]

This feels pretty magical. Ideally we would have a general purpose
isSelectionCollapsedAnywhere method, but that is probably impractical because it
involves keeping track and iterating over every shadow root.

[dgozman, 2016/12/29 19:02:58]

Does shadow dom v1 solve that? I think that we only care about
Document.getDeepSelection if that's possible to implement. Adding more checks
like this does not scale, unfortunately.

[dgozman, 2016/12/30 00:42:33]

if (this.propertiesTreeOutline.element.shadowRoot.firstChild && ...)

[einbinder, 2016/12/30 02:17:37]

Done.

+      return;
+
     if (this._checkWillCancelEditing())
       return;