Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1283)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 2605993002: Experiment with more aggressive MSE GC on memory pressure (Closed)
Patch Set: Improve feature handling (CR feedback) Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 6cca9259bee2907acdacd322b5a741ee44d1a6f5..ca713ae9b3329a20ea6baff656e910ba598c403d 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -550,6 +550,13 @@ WebPreferences RenderViewHostImpl::ComputeWebkitPrefs() {
"max_keyframe_distance_ms",
base::TimeDelta::FromSeconds(10).InMilliseconds()));
+ // TODO(avayvod, asvitkine): Query the value directly when it is available in
DaleCurtis 2017/01/26 23:07:36 TODO(servolk? :)
servolk 2017/01/27 00:52:13 Done.
+ // the renderer process. See https://crbug.com/681160.
+ prefs.mse_force_gc_on_memory_pressure =
+ variations::GetVariationParamByFeatureAsBool(
+ media::kReduceMSEBuffersOnMemoryPressure,
+ "mse_force_gc_on_memory_pressure", false);
DaleCurtis 2017/01/26 23:07:36 Not sure if we need two variations here or if the
servolk 2017/01/27 00:52:13 We need to have at least 3 states: 1. No action on
+
std::map<std::string, std::string> expensive_background_throttling_prefs;
variations::GetVariationParamsByFeature(
features::kExpensiveBackgroundTimerThrottling,
« no previous file with comments | « no previous file | content/public/common/common_param_traits_macros.h » ('j') | content/public/common/web_preferences.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698