Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: content/browser/BUILD.gn

Issue 2605973002: WebContentsVideoCapture Cleanup: Gut-out dead code, and tighten BUILDs. (Closed)
Patch Set: Another BUILD file fix. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/BUILD.gn
diff --git a/content/browser/BUILD.gn b/content/browser/BUILD.gn
index 85b90cedf36b16ee86f463189cfa019615fb633c..e816394e1cff7370867520238c8044f37ecb2a3d 100644
--- a/content/browser/BUILD.gn
+++ b/content/browser/BUILD.gn
@@ -864,11 +864,6 @@ source_set("browser") {
"media/audio_stream_monitor.h",
"media/capture/audio_mirroring_manager.cc",
"media/capture/audio_mirroring_manager.h",
- "media/capture/cursor_renderer.h",
- "media/capture/cursor_renderer_aura.cc",
- "media/capture/cursor_renderer_aura.h",
- "media/capture/cursor_renderer_mac.h",
- "media/capture/cursor_renderer_mac.mm",
"media/capture/desktop_capture_device_uma_types.cc",
"media/capture/desktop_capture_device_uma_types.h",
"media/capture/image_capture_impl.cc",
@@ -879,14 +874,6 @@ source_set("browser") {
"media/capture/web_contents_audio_muter.h",
"media/capture/web_contents_tracker.cc",
"media/capture/web_contents_tracker.h",
- "media/capture/web_contents_video_capture_device.cc",
- "media/capture/web_contents_video_capture_device.h",
- "media/capture/window_activity_tracker.cc",
- "media/capture/window_activity_tracker.h",
- "media/capture/window_activity_tracker_aura.cc",
- "media/capture/window_activity_tracker_aura.h",
- "media/capture/window_activity_tracker_mac.h",
- "media/capture/window_activity_tracker_mac.mm",
"media/cdm_registry_impl.cc",
"media/cdm_registry_impl.h",
"media/media_devices_permission_checker.cc",
@@ -1507,26 +1494,48 @@ source_set("browser") {
"//third_party/webrtc/media:rtc_media_base",
"//third_party/webrtc/modules/desktop_capture:primitives",
]
- if (!is_ios) {
- defines += [ "ENABLE_SCREEN_CAPTURE=1" ]
- }
+
if (is_linux || is_mac || is_win) {
sources += [
"media/capture/desktop_capture_device.cc",
"media/capture/desktop_capture_device.h",
]
- if (use_aura) {
- sources += [
- "media/capture/aura_window_capture_machine.cc",
- "media/capture/aura_window_capture_machine.h",
- "media/capture/desktop_capture_device_aura.cc",
- "media/capture/desktop_capture_device_aura.h",
- ]
- }
deps += [ "//third_party/webrtc/modules/desktop_capture" ]
}
}
+ # Desktop screen capture implementations that are not dependent on WebRTC.
+ if (is_linux || is_mac || is_win) {
+ defines += [ "ENABLE_SCREEN_CAPTURE=1" ]
+ sources += [
+ "media/capture/cursor_renderer.h",
+ "media/capture/web_contents_video_capture_device.cc",
+ "media/capture/web_contents_video_capture_device.h",
+ "media/capture/window_activity_tracker.cc",
+ "media/capture/window_activity_tracker.h",
+ ]
+ if (use_aura) {
+ sources += [
+ "media/capture/aura_window_capture_machine.cc",
+ "media/capture/aura_window_capture_machine.h",
+ "media/capture/cursor_renderer_aura.cc",
+ "media/capture/cursor_renderer_aura.h",
+ "media/capture/desktop_capture_device_aura.cc",
+ "media/capture/desktop_capture_device_aura.h",
+ "media/capture/window_activity_tracker_aura.cc",
+ "media/capture/window_activity_tracker_aura.h",
+ ]
+ }
+ if (is_mac) {
+ sources += [
+ "media/capture/cursor_renderer_mac.h",
+ "media/capture/cursor_renderer_mac.mm",
+ "media/capture/window_activity_tracker_mac.h",
+ "media/capture/window_activity_tracker_mac.mm",
+ ]
+ }
+ }
+
if (is_win) {
sources -= [ "device_sensors/data_fetcher_shared_memory_default.cc" ]
defines += [
@@ -1785,7 +1794,10 @@ source_set("browser") {
"//mojo/android:libsystem_java",
"//ui/android",
]
- defines += [ "APPCACHE_USE_SIMPLE_CACHE" ]
+ defines += [
+ "APPCACHE_USE_SIMPLE_CACHE",
+ "ENABLE_SCREEN_CAPTURE=1",
+ ]
libs += [ "jnigraphics" ]
} else {
# Not Android.
@@ -1858,10 +1870,6 @@ source_set("browser") {
]
} else { # Not aura.
sources -= [
- "media/capture/cursor_renderer_aura.cc",
- "media/capture/cursor_renderer_aura.h",
- "media/capture/window_activity_tracker_aura.cc",
- "media/capture/window_activity_tracker_aura.h",
"renderer_host/compositor_resize_lock_aura.cc",
"renderer_host/compositor_resize_lock_aura.h",
"renderer_host/input/synthetic_gesture_target_aura.cc",

Powered by Google App Engine
This is Rietveld 408576698