Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1997)

Unified Diff: appengine/findit/waterfall/extract_deps_info_pipeline.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)
Patch Set: rebase Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/extract_deps_info_pipeline.py
diff --git a/appengine/findit/waterfall/extract_deps_info_pipeline.py b/appengine/findit/waterfall/extract_deps_info_pipeline.py
index 7f8a7133a835299d65f7afccdd2213d5c2c20b32..b9258c1ed1f6e7225c44fc6f3b9f3ce1a32eb0f7 100644
--- a/appengine/findit/waterfall/extract_deps_info_pipeline.py
+++ b/appengine/findit/waterfall/extract_deps_info_pipeline.py
@@ -46,8 +46,8 @@ def _GetOSPlatformName(master_name, builder_name): # pragma: no cover
def _GetDependencies(chromium_revision, os_platform):
"""Returns the dependencies used by the specified chromium revision."""
deps = {}
- dep_fetcher=chrome_dependency_fetcher.ChromeDependencyFetcher(
- CachedGitilesRepository(HttpClientAppengine()))
+ dep_fetcher = chrome_dependency_fetcher.ChromeDependencyFetcher(
+ CachedGitilesRepository.Factory(HttpClientAppengine()))
for path, dependency in dep_fetcher.GetDependency(
chromium_revision, os_platform).iteritems():
deps[path] = {
@@ -80,8 +80,8 @@ def _DetectDependencyRolls(change_logs, os_platform):
}
"""
deps_rolls = {}
- dep_fetcher=chrome_dependency_fetcher.ChromeDependencyFetcher(
- CachedGitilesRepository(HttpClientAppengine()))
+ dep_fetcher = chrome_dependency_fetcher.ChromeDependencyFetcher(
+ CachedGitilesRepository.Factory(HttpClientAppengine()))
for revision, change_log in change_logs.iteritems():
# Check DEPS roll only if the chromium DEPS file is changed by the CL.
for touched_file in change_log['touched_files']:
« no previous file with comments | « appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698