appengine/findit/util_scripts/git_checkout/test/local_git_parsers_test.py - Issue 2605943002: Removing the mutation in the factories for getting dep repositories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/util_scripts/git_checkout/test/local_git_parsers_test.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)

Patch Set: rebase Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/util_scripts/git_checkout/local_git_repository.py ('k') | appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/util_scripts/git_checkout/test/local_git_parsers_test.py

diff --git a/appengine/findit/util_scripts/git_checkout/test/local_git_parsers_test.py b/appengine/findit/util_scripts/git_checkout/test/local_git_parsers_test.py

index 562712a656b310c6297257584db107efcbd2258a..283eab33972ffcbb7ef2ad5bf6b75c703341e387 100644

--- a/appengine/findit/util_scripts/git_checkout/test/local_git_parsers_test.py

+++ b/appengine/findit/util_scripts/git_checkout/test/local_git_parsers_test.py

@@ -122,7 +122,7 @@ class LocalGitParsersTest(unittest.TestCase):

'c9cc182781484f9010f062859cda048afefefefe')

changelog = local_git_parsers.GitChangeLogParser()(output, 'https://repo')

- self.assertTrue(expected_changelog.ToDict(), changelog.ToDict())

+ self.assertDictEqual(expected_changelog.ToDict(), changelog.ToDict())

def testGitChangeLogParserParseEmptyOutput(self):

self.assertIsNone(local_git_parsers.GitChangeLogParser()(None, 'repo'))