Removing the mutation in the factories for getting dep repositories

appengine/findit/crash/findit_for_chromecrash.py

Index: appengine/findit/crash/findit_for_chromecrash.py
diff --git a/appengine/findit/crash/findit_for_chromecrash.py b/appengine/findit/crash/findit_for_chromecrash.py
index c50fe2d6a34dc9168ac3840d02664924710ef0c4..fa255bb7b9ab3d80c1b1acc20ad1c018e10d41b9 100644
--- a/appengine/findit/crash/findit_for_chromecrash.py
+++ b/appengine/findit/crash/findit_for_chromecrash.py
@@ -49,28 +49,16 @@ class FinditForChromeCrash(Findit):
 
   # TODO(http://crbug.com/659354): remove the dependency on CrashConfig
   # entirely, by passing the relevant data as arguments to this constructor.
-  def __init__(self, repository):
-    super(FinditForChromeCrash, self).__init__(repository)
+  def __init__(self, get_repository):
+    super(FinditForChromeCrash, self).__init__(get_repository)
     component_classifier_config = CrashConfig.Get().component_classifier
 
     self._stacktrace_parser = ChromeCrashParser()
 
-    # TODO(crbug.com/677224): should replace this with an actual factory.
-    def MutateTheRepo(dep_url): # pragma: no cover
-      """A factory function for returning ``Repository`` objects.
-
-      The current definition captures the functionality of before
-      we factored out this factory method. That is, it's not really a
-      "factory" but rather mutates the main repo object in place. In
-      the future this should be changed to do the right thing instead.
-      """
-      repository.repo_url = dep_url
-      return repository
-
     # The top_n is the number of components we should return as
     # components suggestion results.
     self._predator = Predator(
-        cl_classifier = ChangelistClassifier(repository, MutateTheRepo),
+        cl_classifier = ChangelistClassifier(get_repository),
         component_classifier = ComponentClassifier(
             [Component(component_name, path_regex, function_regex)
             for path_regex, function_regex, component_name