Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2283)

Unified Diff: appengine/findit/crash/crash_pipeline.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)
Patch Set: rebase Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/changelist_classifier.py ('k') | appengine/findit/crash/findit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/crash_pipeline.py
diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
index 31355eac18df05dc5f820e9a71906f5f0f4ba0a2..7966d0c5c4edc4444f51401ba311f4b49ab8ef38 100644
--- a/appengine/findit/crash/crash_pipeline.py
+++ b/appengine/findit/crash/crash_pipeline.py
@@ -22,7 +22,7 @@ from model import analysis_status
# TODO(http://crbug.com/659346): write complete coverage tests for this.
-def FinditForClientID(client_id, repository): # pragma: no cover
+def FinditForClientID(client_id, get_repository): # pragma: no cover
"""Construct a Findit object from a client id string specifying the class.
We cannot pass Findit objects to the various methods in
@@ -52,7 +52,7 @@ def FinditForClientID(client_id, repository): # pragma: no cover
raise ValueError('FinditForClientID: '
'unknown or unsupported client %s' % client_id)
- return cls(repository)
+ return cls(get_repository)
# Some notes about the classes below, for people who are not familiar
@@ -93,7 +93,7 @@ class CrashBasePipeline(BasePipeline):
self._crash_identifiers = crash_identifiers
self._findit = FinditForClientID(
client_id,
- CachedGitilesRepository(HttpClientAppengine()))
+ CachedGitilesRepository.Factory(HttpClientAppengine()))
@property
def client_id(self): # pragma: no cover
« no previous file with comments | « appengine/findit/crash/changelist_classifier.py ('k') | appengine/findit/crash/findit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698