Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2224)

Unified Diff: appengine/findit/crash/test/findit_test.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/findit_test.py
diff --git a/appengine/findit/crash/test/findit_test.py b/appengine/findit/crash/test/findit_test.py
index f0aa4351c9c5b105123d163f72e9b2bfe0d7a07c..0756161f06dd468a62755e59faaca0ae43395f6f 100644
--- a/appengine/findit/crash/test/findit_test.py
+++ b/appengine/findit/crash/test/findit_test.py
@@ -13,7 +13,9 @@ from crash.test.crash_pipeline_test import DummyCrashData
from crash.test.predator_testcase import PredatorTestCase
from model.crash.fracas_crash_analysis import FracasCrashAnalysis
-MOCK_REPOSITORY = None
+
+MOCK_GET_REPOSITORY = lambda _: None # pragma: no cover
+
class UnsupportedClient(Findit): # pylint: disable=W0223
# TODO(http://crbug.com/659346): this isn't being called for some reason.
@@ -27,7 +29,7 @@ class UnsupportedClient(Findit): # pylint: disable=W0223
return {}
def __init__(self, client_id=None):
- super(UnsupportedClient, self).__init__(MOCK_REPOSITORY)
+ super(UnsupportedClient, self).__init__(MOCK_GET_REPOSITORY)
if client_id is None:
client_id = 'unsupported_client'
self._client_id = client_id
@@ -37,7 +39,7 @@ class MockFindit(Findit): # pylint: disable = W
"""Overwrite abstract method of Findit for testing."""
def __init__(self):
- super(MockFindit, self).__init__(MOCK_REPOSITORY)
+ super(MockFindit, self).__init__(MOCK_GET_REPOSITORY)
@classmethod
def _ClientID(cls):

Powered by Google App Engine
This is Rietveld 408576698