Removing the mutation in the factories for getting dep repositories

appengine/findit/crash/findit_for_chromecrash.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from google.appengine.ext import ndb
 
 from common import appengine_util
 from crash import detect_regression_range
@@ skipping 31 matching lines @@
       logging.warning('FinditForChromeCrash is abstract, '
           'but someone constructed an instance and called _ClientID')
     else:
       logging.warning(
           'FinditForChromeCrash subclass %s forgot to implement _ClientID',
           cls.__name__)
     raise NotImplementedError()
 
   # TODO(http://crbug.com/659354): remove the dependency on CrashConfig
   # entirely, by passing the relevant data as arguments to this constructor.
-  def __init__(self, repository):
-    super(FinditForChromeCrash, self).__init__(repository)
+  def __init__(self, get_repository):
+    super(FinditForChromeCrash, self).__init__(get_repository)
     component_classifier_config = CrashConfig.Get().component_classifier
 
     self._stacktrace_parser = ChromeCrashParser()
 
-    # TODO(crbug.com/677224): should replace this with an actual factory.
-    def MutateTheRepo(dep_url): # pragma: no cover
-      """A factory function for returning ``Repository`` objects.
-
-      The current definition captures the functionality of before
-      we factored out this factory method. That is, it's not really a
-      "factory" but rather mutates the main repo object in place. In
-      the future this should be changed to do the right thing instead.
-      """
-      repository.repo_url = dep_url
-      return repository
-
     # The top_n is the number of components we should return as
     # components suggestion results.
     self._predator = Predator(
-        cl_classifier = ChangelistClassifier(repository, MutateTheRepo),
+        cl_classifier = ChangelistClassifier(get_repository),
         component_classifier = ComponentClassifier(
             [Component(component_name, path_regex, function_regex)
             for path_regex, function_regex, component_name
             in component_classifier_config['path_function_component']],
             component_classifier_config['top_n']),
         project_classifier = ProjectClassifier())
 
   def _InitializeAnalysis(self, model, crash_data):
     super(FinditForChromeCrash, self)._InitializeAnalysis(model, crash_data)
     # TODO(wrengr): see Note#1
@@ skipping 95 matching lines @@
 
   def GetAnalysis(self, crash_identifiers):
     # TODO: inline FracasCrashAnalysis.Get stuff here.
     return FracasCrashAnalysis.Get(crash_identifiers)
 
   def ProcessResultForPublishing(self, result, key):
     """Fracas specific processing of result data for publishing."""
     result['feedback_url'] = _FRACAS_FEEDBACK_URL_TEMPLATE % (
         appengine_util.GetDefaultVersionHostname(), key)
     return result